Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compact switch statement in Button component #542

Merged
merged 5 commits into from
Nov 22, 2019

Conversation

ashmaroli
Copy link
Member

Instead of using separate statements involving dot-notation, bracket-notation can be used to dynamically interpolate property key and consequently reduce the no. of statements in the switch() expression.

Copy link
Member

@mertkahyaoglu mertkahyaoglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one little comment.

src/components/Button.js Outdated Show resolved Hide resolved
@ashmaroli ashmaroli merged commit 1b32785 into jekyll:master Nov 22, 2019
@ashmaroli ashmaroli deleted the compact-switch-button branch November 22, 2019 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants