Convert DataGUI into a bona fide component #546
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to minimize repeated logic.
(However, there's still some logic repeated in the three components that consume
DataGUI
:DataFileNew
,DataFileEdit
andConfiguration
. But that seems to be necessary at the moment.)Currently on
master
,DataGUI
is justMetafields
rendered with propdataview: true
and the inputs for editing data file path being additionally implemented for bothDataFileNew
andDataFileEdit
.Another internal change is to use input elements'
ref
value on save instead of setting the parent component'sstate
and then reading from that value.