Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render a layout-picker to select layouts #558

Merged
merged 14 commits into from
Mar 9, 2020
Merged

Render a layout-picker to select layouts #558

merged 14 commits into from
Mar 9, 2020

Conversation

ashmaroli
Copy link
Member

Depends on #543
Part of Phase 2 of adding support for selecting layouts, categories, tags via the interface..

@ashmaroli ashmaroli marked this pull request as ready for review March 2, 2020 12:04
mertkahyaoglu
mertkahyaoglu approved these changes Mar 8, 2020
View reviewed changes
Copy link
Member

@mertkahyaoglu mertkahyaoglu left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We should add layout to the info text we show for metafields like;

You can use special keys like date, file, image, layout for user-friendly functionalities.

@ashmaroli ashmaroli merged commit b01465d into jekyll:master Mar 9, 2020
@ashmaroli ashmaroli deleted the layout-picker branch March 9, 2020 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mertkahyaoglu mertkahyaoglu mertkahyaoglu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ashmaroli @mertkahyaoglu