-
-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import site metadata into admin interface #543
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can fetch site meta once in App.js and use it in other places.
In this implementation, I saw fetchSitemeta
is destructed in several places but not used. What was the reason for that?
Fetching just once is not enough. The reason we need to continuously fetch is because the data exposed at this endpoint ( Similarly, a layout created outside the admin interface (with the interface already loaded in the browser) should be reflected in the metafield data once the user mounts an
🤦 I guess I missed it when I was adding changes to git index. All those places will contain a call to |
I think I can centralize the |
To allow selecting existing categories, layouts and tags via the interface.
The idea is to fetch the data related to above every time a page / draft / document is created / edited so that the
Metafields
component always reflects the latest status (i.e. a category added to one post will be available for the next post being edited).Current;y, this is just Phase I of supporting categories and tags via the interface.
Phase II will involve
Metafields
utilizing the imported site meta.