add Rubocop #23
Merged
add Rubocop #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DirtyF
force-pushed
the
pull/rubocop
branch
2 times, most recently
from
7e23906
to
17ef81b
Compare
DirtyF
reviewed
Oct 25, 2017
Gemfile
Outdated
| gems.concat config["gems"] if config.include? "gems" | ||
| gems.concat config["plugins"] if config.include? "plugins" | ||
| gems << "pygments.rb" if config["highlighter"] == "pygments" | ||
| gems << "rubocop" |
There was a problem hiding this comment.
Is this the right way to add the gem? Travis is failing 😕
There was a problem hiding this comment.
No, this block is only evaluated if jekyll is cloned. Add gem “rubocop” above if Dir.exist
parkr
requested changes
Oct 25, 2017
.rubocop.yml
Outdated
| @@ -1,12 +1,7 @@ | |||
| inherit_gem: | |||
| jekyll: .rubocop.yml | |||
|
|
|||
| Metrics/LineLength: | |||
| AllCops: | |||
| TargetRubyVersion: 2.4 | |||
There was a problem hiding this comment.
This should be the lowest version we support.
|
|
||
| Style/FileName: | ||
| Enabled: false | ||
| - jekyll/**/* |
Gemfile
Outdated
| gems.concat config["gems"] if config.include? "gems" | ||
| gems.concat config["plugins"] if config.include? "plugins" | ||
| gems << "pygments.rb" if config["highlighter"] == "pygments" | ||
| gems << "rubocop" |
There was a problem hiding this comment.
No, this block is only evaluated if jekyll is cloned. Add gem “rubocop” above if Dir.exist
|
Build is passing now. Thanks for the review @parkr |
|
@jekyllbot: merge +dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR automatically created for @DirtyF.