Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disabling of jekyll-feed while in development #370

Merged
merged 5 commits into from
Jun 5, 2022
Merged

Allow disabling of jekyll-feed while in development #370

merged 5 commits into from
Jun 5, 2022

Conversation

sylhare
Copy link
Contributor

@sylhare sylhare commented Jun 1, 2022

SInce #346 was not getting any traction, I addressed the code review comments and created this PR.

@sylhare
Copy link
Contributor Author

sylhare commented Jun 2, 2022

Oh it seems I need approval to run the workflow, @parkr would you be able to take a look. Thanks!

@sylhare
Copy link
Contributor Author

sylhare commented Jun 3, 2022

Ah it gets:


lib/jekyll-feed/generator.rb:9:5: C: Metrics/AbcSize: Assignment Branch Condition size for generate is too high. [<5, 23, 9> 25.2/21]
    def generate(site) ...
    ^^^^^^^^^^^^^^^^^^
lib/jekyll-feed/generator.rb:9:5: C: Metrics/CyclomaticComplexity: Cyclomatic complexity for generate is too high. [8/7]
    def generate(site) ...
    ^^^^^^^^^^^^^^^^^^

@parkr
Copy link
Member

parkr commented Jun 5, 2022

@jekyllbot: merge +minor

@jekyllbot jekyllbot merged commit aa9ae0e into jekyll:master Jun 5, 2022
jekyllbot added a commit that referenced this pull request Jun 5, 2022
@tadamcz
Copy link

tadamcz commented Oct 13, 2022

This change appears in the README on the master branch, but has not been released, which can be confusing. Especially since earlier versions fail silently.

I had to use:

gem 'jekyll-feed', git: "git@github.com:jekyll/jekyll-feed.git"

@parkr parkr mentioned this pull request Oct 15, 2022
@parkr
Copy link
Member

parkr commented Oct 15, 2022

0.17.0 is out now.

shushugah added a commit to techworkersco/twc-site that referenced this pull request Jan 22, 2023
With 6 languages/collections, feed generation is arduous so disable in development
jekyll/jekyll-feed#370
@jekyll jekyll locked and limited conversation to collaborators Oct 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants