New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes wordpress importer and require path error. #85

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@volker48
Copy link

volker48 commented Nov 18, 2013

The import command was using the wrong path for the location of
importers. Also fixes the option keys in the WordPress importer.
The importer was incorrectly fetching the keys as strings instead of
symbols. The others importers will still need to be updated.

Fixes wordpress importer and require path error.
The import command was using the wrong path for the location of
importers. Also fixes the option keys in the WordPress importer. The others
will still need to be updated
@JohnMaguire

This comment has been minimized.

Copy link

JohnMaguire commented Nov 18, 2013

Is this bug similar to the one responsible for #84?

@parkr

This comment has been minimized.

Copy link
Member

parkr commented Nov 18, 2013

The current version is setup to work with jekyll/jekyll#1706. I'll update the docs.

@parkr parkr closed this Nov 18, 2013

@volker48

This comment has been minimized.

Copy link

volker48 commented Nov 19, 2013

After digging into some of the code I figured there were some changes in Jekyll, but Isn't this path still going to be a problem? I'm not super familiar with Ruby so maybe some magic will fix it, but the current code is missing the "importers" directory and one level of nesting in the require. I'm interested to know either way.

  •      require File.join(File.dirname(**FILE**), "..", "jekyll-import", "#{migrator}.rb")
    
  •     require File.join(File.dirname(**FILE**), "..", "..", "jekyll-import", "importers", "#{migrator}.rb")
    
@parkr

This comment has been minimized.

Copy link
Member

parkr commented Nov 19, 2013

Kind of fixed it here: 1086ac2

Ultimately this command will be deleted once that jekyll pr is merged.

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.