Fixes wordpress importer and require path error. #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The import command was using the wrong path for the location of importers. Also fixes the option keys in the WordPress importer. The others will still need to be updated
|
Is this bug similar to the one responsible for #84? |
|
The current version is setup to work with jekyll/jekyll#1706. I'll update the docs. |
|
After digging into some of the code I figured there were some changes in Jekyll, but Isn't this path still going to be a problem? I'm not super familiar with Ruby so maybe some magic will fix it, but the current code is missing the "importers" directory and one level of nesting in the require. I'm interested to know either way.
|
|
Kind of fixed it here: 1086ac2 Ultimately this command will be deleted once that jekyll pr is merged. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The import command was using the wrong path for the location of
importers. Also fixes the option keys in the WordPress importer.
The importer was incorrectly fetching the keys as strings instead of
symbols. The others importers will still need to be updated.