-
-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop commander #1706
Merged
Merged
Drop commander #1706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is all ready to go and can be tested with jekyll-import 0.1.0.beta4. |
/cc @mattr- |
This is for sure a 1.4 change, and I'm being extra conservative in merging pull requests that change code in anticipation of a 1.3.1 sooner rather than later. |
@mattr- Ok, doesn't seem like v1.3.0 has many significant bugs so we should be good to go. |
This was referenced Nov 18, 2013
…rter. @mojombo, this look better?
mattr-
added a commit
that referenced
this pull request
Dec 11, 2013
mattr-
added a commit
that referenced
this pull request
Dec 11, 2013
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mojombo wrote something in the
commando
branch which I just extracted out into mercenary (the name was TPW's idea 😉)Commander sucks, so lets kiss it goodbye!