Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement URL conflict checking in jekyll-doctor. #1389

Merged
merged 4 commits into from
Aug 18, 2013
Merged

Implement URL conflict checking in jekyll-doctor. #1389

merged 4 commits into from
Aug 18, 2013

Conversation

parkr
Copy link
Member

@parkr parkr commented Aug 6, 2013

Satisfies #1077.
Alternative to #1361.

@parkr
Copy link
Member Author

parkr commented Aug 6, 2013

Sample output:

~/code/jekyll/tsite$ ../bin/jekyll doctor
Configuration file: /Users/parker/code/jekyll/tsite/_config.yml
          Conflict: The URL '/Users/parker/code/jekyll/tsite/_site/index.html' is the destination for the following pages: index.html, something/index.html

@kelvinst
Copy link

kelvinst commented Aug 8, 2013

Nice feature (=
Revised and good to merge

@parkr
Copy link
Member Author

parkr commented Aug 8, 2013

@mattr-

mattr-
mattr- reviewed Aug 8, 2013
View reviewed changes
lib/jekyll/commands/doctor.rb
urls = {}
urls = collect_urls(urls, site.pages, site.dest)
urls = collect_urls(urls, site.posts, site.dest)
#urls = collect_urls(urls, site.static_files)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💣 the comment, please 😃

@mattr-
Copy link
Member

mattr- commented Aug 8, 2013

Just one small nitpick and then I think it's good to go.

@parkr
Copy link
Member Author

parkr commented Aug 8, 2013

Also aborting if unhealthy returns true

@maul-esel maul-esel mentioned this pull request Aug 17, 2013
Closed
parkr
parkr reviewed Aug 17, 2013
View reviewed changes
lib/jekyll/commands/doctor.rb
[
deprecated_relative_permalinks(site),
conflicting_urls(site)
].any?
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattr- I'm worried this will only evaluate until one of them returns true.

@mattr-
Copy link
Member

mattr- commented Aug 18, 2013

👍 :shipit:

mattr- added a commit that referenced this pull request Aug 18, 2013
@mattr-
Merge pull request #1389 from mojombo/doctor-conflicting-permalinks
820f526 
Implement URL conflict checking in `jekyll-doctor`.
@mattr- mattr- merged commit 820f526 into master Aug 18, 2013
mattr- added a commit that referenced this pull request Aug 18, 2013
@mattr-
Update history to reflect merge of #1389
d40e794
@parkr parkr mentioned this pull request Aug 18, 2013
Closed
@parkr parkr deleted the doctor-conflicting-permalinks branch August 19, 2013 16:32
@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
frozen-due-to-age
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.
4 participants
@parkr @kelvinst @mattr- @jekyllbot