-
-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maruku fenced code blocks #1799
Conversation
|
||
# allow fenced code blocks (new in Maruku 0.7.0) | ||
if @config['maruku']['fenced_code_blocks'] | ||
MaRuKu::Globals[:fenced_code_blocks] = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not just set the value of the config to the the value of the Globals? i.e.
MaRuKu::Globals[:fenced_code_blocks] = !!@config['maruku']['fenced_code_blocks']
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All right, Captain Picky, I've updated the PR with your suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😃 ❤️
LGTM! @mattr-? |
Maruku 0.7.1 has been released, which includes @konklone's patch as well as several other bugfixes. See https://github.com/bhollis/maruku/blob/master/CHANGELOG.md for details. |
This adds support for the
fenced_code_blocks
option in Maruku, and adds a test that verifies that it works.Note: This test accommodates for the newlines that Maruku 0.7.0 currently puts around the internals of
<code>
blocks generated byfenced_code_blocks
. If my PR fixing this at bhollis/maruku#112 is merged in, and Maruku's version is bumped, I'll follow up with another PR that bumps Jekyll's Maruku version to it, and removes the newlines from this test.