add support for unpublished drafts #2164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I keep all my ideas for blog posts as drafts in my draft folder. However I'm only really working on a couple at once. This let's me mark drafts that I'm not working on right now as unpublished so they don't clutter the site while I'm checking on the other drafts.
|
Looks fine to me. A draft is a post, so I don't see why we'd need to unit test that logic twice. @parkr? |
parkr
added a commit
that referenced
this pull request
Mar 23, 2014
parkr
added a commit
that referenced
this pull request
Mar 23, 2014
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I keep all my ideas for blog posts as drafts in my draft folder. However I'm
only really working on a couple at once. This let's me mark drafts that I'm
not working on right now as unpublished so they don't clutter the site while
I'm checking on the other drafts.
I only added feature tests since I didn't quite grok if there was something
to add to the unit tests. Please let me know if I should add tests in there
as well.