Remove adapters deprecation warning #3529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'method adapters is deprecated. use profiles instead' This warning was showing up because the project was using the gem 'simplecov-gem-adapter' which uses the old syntax. * Remove the gem dependency * Add a profile with the same setup that the gem has
|
|
||
| add_group 'Binaries', '/bin/' | ||
| add_group 'Libraries', '/lib/' | ||
| end |
|
Great!! |
|
@parkr thanks! what happened to the comments you made? were they implemented? |
|
sweet! thanks @parkr! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys,
This pull request removes the following deprecation warning from simplecov.
The new way is using profiles. The warning comes from the gem 'simplecov-gem-adapter', which haven't been updated for the last 4 years.
In this pull request l removed the gem dependency and added a new profile with some of the settings that were in the gem. l thought it was better this way -instead of making a PR to the gem- because this way, we remove a dependency and it will be easier to customize the profile in the future.
What do you think?
Cheers!