Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate caches and create a _cache folder for *all* to use. #4227

Closed
envygeeks opened this issue Dec 5, 2015 · 18 comments · Fixed by #7158
Closed

Consolidate caches and create a _cache folder for *all* to use. #4227

envygeeks opened this issue Dec 5, 2015 · 18 comments · Fixed by #7158
Assignees
Labels
frozen-due-to-age has-pull-request Somebody suggested a solution to fix this issue pinned
Milestone

Comments

@envygeeks
Copy link
Contributor

Today we did an audit for our biggest Jekyll site and noticed it has like 8 cache folders, this is pretty big and unwieldy, it also makes it harder for us to control the caching on our build servers. We should create a _cache folder and consolidate all Jekyll caching into that folder, and then ask plugin authors to place their caches in that folder too with or without prefixes. Exp:

  • _cache/jekyll/incremental
  • _cache/jekyll-assets/assets
  • _cache/jekyll/sass

Now cleanup went from "let me figure out what is what" to rm -rf _cache

@envygeeks
Copy link
Contributor Author

/cc @jekyll/core

@parkr
Copy link
Member

parkr commented Dec 5, 2015

Let's add the removal of these caches to the jekyll clean command.

@alfredxing
Copy link
Member

👍 Good idea! It'd be easier for users in terms of ignoring these files for source control as well.

@parkr
Copy link
Member

parkr commented Dec 7, 2015

Are any sites using _cache for content? That's what worries me here.

@envygeeks
Copy link
Contributor Author

@parkr make it configurable then, out of all the configuration options that a system should have, where it caches is a high-priority unless it uses system caches, and especially if it uses local directory caching. We allow it on Jekyll-Assets which gives users flexibility on where they place their cache and how, it's not a bad idea for Jekyll and I don't know the YACO applies here because for people like me who build hundreds of sites putting our caches in a global directory and controlling them gives us much more flexibility in our build systems, how we build all that, and it gives the average user more flexibility in how dirty their folder is at the root.

@jekyllbot jekyllbot added the stale Nobody stepped up to work on this issue. label Jun 6, 2016
@envygeeks
Copy link
Contributor Author

Reopening at the request of @nhoizey
/cc @parkr @jekyll/core @jekyll/ecosystem

@jekyllbot jekyllbot removed the stale Nobody stepped up to work on this issue. label Sep 1, 2016
@parkr parkr reopened this Sep 1, 2016
@envygeeks
Copy link
Contributor Author

Oops, thought I did reopen it, thanks for doing it @parkr.

@mattr-
Copy link
Member

mattr- commented Sep 1, 2016

👍 for this idea from me.

@pathawks
Copy link
Member

pathawks commented Sep 1, 2016

I very much approve of this idea 👍

Are any sites using _cache for content?

Yeah, how would this work? Don’t want anybody to upgrade without reading the docs and end up having some of their data "cleaned" away by mistake.

@envygeeks
Copy link
Contributor Author

I think we would have to do a pre-4.0 pre-flight warning, to let people we know that we are implementing a new folder and that it could be destroyed by "jekyll clean" but we could always use .jekyll-cache or something like that which in theory shouldn't conflict and if it does I'm okay with that the latter folder conflicting because one would expect any .jekyll prefixed folder to be reserved.

@envygeeks
Copy link
Contributor Author

Regardless of this change I think a pre-flight warning on 4.0 is a good idea, when we moved to Jekyll 3 we got so many tickets by people taken aback from changes that were in the works for months, so we should really start doing random "master branch" feature posts to start preparing people to what's coming up.

@jekyllbot

This comment has been minimized.

@jekyllbot jekyllbot added the stale Nobody stepped up to work on this issue. label Nov 3, 2016
@DirtyF DirtyF added this to the 4.0 milestone Nov 3, 2016
@pathawks

This comment has been minimized.

@jekyllbot jekyllbot removed the stale Nobody stepped up to work on this issue. label Dec 28, 2016
@jekyllbot jekyllbot added the stale Nobody stepped up to work on this issue. label Jan 23, 2017
@nhoizey

This comment has been minimized.

@jekyllbot jekyllbot removed the stale Nobody stepped up to work on this issue. label Mar 23, 2017
@DirtyF DirtyF added the pinned label Mar 23, 2017
@pathawks pathawks reopened this Mar 23, 2017
@nhoizey
Copy link
Contributor

nhoizey commented Jun 23, 2017

Can we agree on the .jekyll-cache name, so that plugins authors can start align, even if there are still no tools in Jekyll to manipulate/clean it?

@envygeeks
Copy link
Contributor Author

@nhoizey I can agree to .jekyll-cache and will even default Jekyll-Assets 3 to using that name.

@nhoizey
Copy link
Contributor

nhoizey commented Jun 26, 2017

@envygeeks great, I'll start using it as well.

@jekyllbot

This comment has been minimized.

@DirtyF DirtyF removed the stale label Feb 22, 2018
@jekyllbot jekyllbot added the has-pull-request Somebody suggested a solution to fix this issue label Jul 25, 2018
@jekyll jekyll locked and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age has-pull-request Somebody suggested a solution to fix this issue pinned
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants