-
-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add script/travis so all people can play with Travis-CI images. #4338
Conversation
@@ -0,0 +1,33 @@ | |||
#!/bin/sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind adding usage info up here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm gonna be honest, this is for programmers so if they can't get usage info from the simple 2 if's they shouldn't be using it. I'm on the fence about whether I wish to comply with this because the script is so simple.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me rephrase that, did you understand how to use it @parkr?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's simple enough, but usage examples save time. It took me a second to understand what $1 and $2 were supposed to do because I had to hunt. I sometimes have to get usage help for things because I use so many tools every day that I can mix them up sometimes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's fair then, after I finish up the ObjectSpace removal I'll add a usage info.
8617019
to
9fee9d3
Compare
Done. |
You rock! 🎉 |
@jekyllbot: merge +dev |
No description provided.