-
-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Page should respect output extension of its permalink #4373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… exit status we aren't expecting
This reverts a bit of the work @willnorris had made to support extensionless permalinks. Using the ‘permalink’ front matter will no longer work as it must allow non-html extensions to be written.
…of the permalink isn't empty
@jekyllbot: merge +bug |
jekyllbot
added a commit
that referenced
this pull request
Jan 18, 2016
@envygeeks Whoops! Didn't see you commenting there. I'll fix up the things you pointed out. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this completes mpc-hc/mpc-hc.org#58 for @XhmikosR.
This PR includes some other enhancements which will make it easier
to move Page over to Renderer and away from Convertible by 3.2.
Fixes #4182, #4193, #4082.