-
-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[site] Document link
Liquid tag
#5182
Conversation
@DirtyF I like it! A couple thoughts:
|
@parkr Done but you should know that It does not seem to work with everything yet. One can link to collection's document or a post but I didn't manage to link to a page. For example on the jekyll website, if I try to link to the help index page: Jekyll will throw an error: Update : fixed with #5199 |
* put link tag before post_url * example of link to a post with link tag
Fixes request made in jekyll#4624 and bug found in jekyll#5182
Can you mention in the documentation that this is unreleased? |
In looking at the Templates page, it's unclear how the Post URL section that immediately follows the Link section differs. Does Link provide a way to link to a collection that was not possible with post_url? Now that we have link, do we still need the post_url approach? I think the post_url section may just need to be deleted. At the very least, some kind of note needs to appear in Post URL that that explains the difference between using link or post_url. |
Also, there's a small typo:
Should be:
|
The only difference is that you don't need to specify file extension with The tag names seem pretty explanatory to me. If it's not obvious enough, we could add something like:
|
Following #4624
Documentation for new
link
tag introduced in v3.2.0cc @jekyll/documentation