Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links to repository on history page are broken #6254

Closed
nickserv opened this issue Jul 29, 2017 · 7 comments · Fixed by #6255
Closed

Links to repository on history page are broken #6254

nickserv opened this issue Jul 29, 2017 · 7 comments · Fixed by #6255
Assignees
Labels
frozen-due-to-age has-pull-request Somebody suggested a solution to fix this issue

Comments

@nickserv
Copy link

nickserv commented Jul 29, 2017

History links are in this mangled format:

https://jekyllrb.com/docs/history/%7B%7B%20site.repository%20%7D%7D/issues/...

/cc @jekyll/documentation

@jekyllbot jekyllbot self-assigned this Jul 29, 2017
@ashmaroli
Copy link
Member

ashmaroli commented Jul 29, 2017

not-reproduced on Google Chrome and Mozilla Firefox, on Windows
The culprit is this {% raw %} tag which was not enclosed within back-ticks raw tags itself

/cc @DirtyF

@ashmaroli
Copy link
Member

Thank you for reporting this @nickmccurdy 😃

@jekyllbot jekyllbot added the has-pull-request Somebody suggested a solution to fix this issue label Jul 29, 2017
@DirtyF DirtyF assigned DirtyF and unassigned jekyllbot Jul 29, 2017
@nickserv
Copy link
Author

@ashmaroli Wow, that broke the whole page? Tricky...

@ashmaroli
Copy link
Member

that broke the whole page?

yep.. that {% raw %} tag caused the break.. but I was wrong in suggesting backticks to rectify it.. Will require wrapping the tag within a raw tag itself..

{% raw %}{% raw %}{% endraw %}

@nickserv
Copy link
Author

I ad a feeling, since otherwise it would just template the tag in backticks.

@pathawks
Copy link
Member

Could we just escape the braces?

{% raw %}

@ashmaroli
Copy link
Member

Could we just escape the braces?

Then we can't have it processed into a code element by enclosing ith within backticks

`&#123;% raw %&#125;`   # => <code>&#123;% raw %&#125;</code>
&#123;% raw %&#125;     # => {% raw %}

`{% raw %}{% raw %}{% endraw %}`     # => <code>{% raw %}</code>

@jekyll jekyll locked and limited conversation to collaborators Jul 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age has-pull-request Somebody suggested a solution to fix this issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants