Docs: store SSL key and cert in site source #7473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Notes that SSL key and certificate must be stored in or symlinked from the site source when using `--ssl-cert` and `--ssl-key`.
parkr
approved these changes
Jan 12, 2019
DirtyF
approved these changes
Jan 12, 2019
|
@jekyllbot: merge +docs |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a 馃敠 documentation change.
This adds a small note that the SSL key and certificate must be stored in or symlinked from the site source when using
--ssl-certand--ssl-key.Users (like me and in #4056) may assume that keys and certs can be stored anywhere. I have not found documentation that notes that they should be in the site source.
However, I am concerned that we should also note that keys and certs should never be added to source control. I have not added this because the Jekyll docs may not be the appropriate place to be giving security advice.