-
-
Notifications
You must be signed in to change notification settings - Fork 10k
-
-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependency constraint to allow for tzinfo v2.0.4 #8516
Comments
In #7562, this is the explanation given:
However, ActiveSupport doesn't use v1.x anymore (since rails/rails@e9425ab) So there shouldn't be an issue with upgrading to v2. |
From the tzinfo changelog
There's a big API change from v1-v2 so it could be tricky to implement. |
@penguoir Yes. The change in API is a significant issue. |
Is this an important thing to work on? I could give it a go... |
It is not at all important as of this posting. |
Hi, I'm the author of tzinfo. I'm not too familiar with Jekyll. It seems that tzinfo is just being used in the tz = TZInfo::Timezone.get(timezone)
difference = -tz.current_period.utc_total_offset The current tz = TZInfo::Timezone.get(timezone)
difference = -tz.current_period.utc_offset Note that |
Hello @philr Your deduction that The whole intention behind the In Jekyll, the timezone is used to maintain consistency of generated dates across different site-builds irrespective of local time. IMO, aligning the UTC offset based on DST is recommended so as to maintain backwards-compatibility and reduce confusion. |
Use the defined offset (in a v1 and v2 compatible way) instead of determining the offset from the difference between local time and UTC. Change the minutes calculation to allow for time zones that don't use hour or half hour offsets (e.g. Australia/Eucla's UTC+08:45). Resolves jekyll#8516.
Use the defined offset (in a v1 and v2 compatible way) instead of determining the offset from the difference between local time and UTC. Change the minutes calculation to allow for time zones that don't use hour or half hour offsets (e.g. Australia/Eucla's UTC+08:45). Resolves jekyll#8516.
@ashmaroli I've submitted pull request #8880 with the proposed change. I've actually used |
Hey there! 👋
I noticed that the constraint you have for tzinfo doesn't allow for the latest version to be used.
The constraint I found was
~> 1.2
, and the latest version available is2.0.4
.Can you look into updating that constraint so our users can use the latest and greatest version? Thanks! 💞
The text was updated successfully, but these errors were encountered: