Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect docs for Windows #1387

Closed
wants to merge 5 commits into from
Closed

Collect docs for Windows #1387

wants to merge 5 commits into from

Conversation

parkr
Copy link
Member

@parkr parkr commented Aug 6, 2013

Still a WIP. 🚧

@parkr parkr mentioned this pull request Aug 6, 2013
@aigarsdz
Copy link
Contributor

aigarsdz commented Aug 6, 2013

I get the problem with incompatible character encoding on Windows all the time because the default code page isn't UTF-8. I added information on how to change it.

@koron
Copy link
Contributor

koron commented Aug 31, 2013

Changing code page seems not good solution on Windows.
Because there are many other tools which expect native code page.
(native code page is 932 in Japan, 936 in China for example)

@aigarsdz
Copy link
Contributor

@koron you are right, but running chcp doesn't change the code page globally. It is changed only for the current session.

@skopp
Copy link

skopp commented Aug 31, 2013

@koron as promised... here I am.

Where to from here? Who's in? who's out? Whose dog is this 🐎 ? It was eating from my garbage.
Seriously, I'm keen on this because I think it will sharpen my Jekyll, Ruby and programming skills so I may someday be half as awesome as @mojombo (I'm not an ass-kisser BTW, but @mojombo has done some awesome stuff in his long and very robotic life).

@parkr
Copy link
Member Author

parkr commented Aug 31, 2013

@skopp Start writing! Add content to the page here and ask to merge into mojombo:windows-docs instead of mojombo:master and we'll collect everything here then merge and release into the site :)

@skopp
Copy link

skopp commented Aug 31, 2013

I'm a bit confused...

I had already forked some time back, and this is what my branches look like:

Now, look at

  • I tried to fork the branch (as seen in the background of that pic), obviously I already have a fork (as seen in the foreground by the contrast between the avatars of the other orgs [un_tinted_] vs the one with my ugly mugshot).

So I tried https://github.com/skopp/jekyll/pull/1 - I'm not sure if that was what is to be done in this situation. It doesn't feel right though, because I'd done that before and normallly the two can merge automatically. By me - ie. by the forker (forkee?) of a motherforked (the mother of the fork) repo.

tldr: 🚁 help?

@parkr
Copy link
Member Author

parkr commented Aug 31, 2013

$ git remote add upstream git://github.com/mojombo/jekyll.git
$ git pull --rebase upstream master

Otherwise, delete your fork and re-fork!

@skopp
Copy link

skopp commented Aug 31, 2013

Otherwise, delete your fork and re-fork!

I thought of that already (but as a last resort). Actually it's normally what I do anyway.
But, I realised that:

  1. this is not the first, or only time I have faced this situation.
  2. I've seen just about the same question mentioned at least twice elsewhere.

$ git remote add upstream git://github.com/mojombo/jekyll.git
$ git pull --rebase upstream master

Thanks... but I was trying to avoid having to do anything locally because surely there must be a way, right?

Nevertheless, just typing this out here before I forget about it - I'll delete and refork for now, and try and find out more from @github or one of the cyborgs on StackOverflow

@skopp
Copy link

skopp commented Sep 1, 2013

@koron
Copy link
Contributor

koron commented Sep 2, 2013

At first, I'll write my install operations in this few days. Wait a moment.

@koron
Copy link
Contributor

koron commented Sep 2, 2013

memo
I use some patches to work jekyll on Windows.
It includes patches for posix-spawn and pygments.rb

A patch for posix-spawn was written by @mattn originally and merged officially.
But it seems not released as gem yet.

A patch for pygments.rb is just suppress a warning message.

@mattn
Copy link

mattn commented Sep 2, 2013

@rtomayko ping

@koron
Copy link
Contributor

koron commented Sep 2, 2013

I have sent a pull request to pygments.rb to support Windows.

@koron
Copy link
Contributor

koron commented Sep 2, 2013

Pull request #1427 is requried too. It is for testing on Windows.

@parkr
Copy link
Member Author

parkr commented Dec 11, 2013

We should get this merged. @mattr-?

@mattr-
Copy link
Member

mattr- commented Dec 11, 2013

Looks good to me. :shipit:

@parkr parkr closed this Dec 11, 2013
@parkr parkr mentioned this pull request Dec 11, 2013
@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants