New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add where filter to filter array objects #1875

Merged
merged 4 commits into from Jan 4, 2014

Conversation

Projects
None yet
4 participants
@parkr
Member

parkr commented Dec 26, 2013

Supersedes #1749. Closes #1749.

Along with #1738, fixes #1735.

Output all pages with the layout staff as JSON:

{{ site.pages | where:"layout","staff" | jsonify }}

ALL THE PROPS TO @benbalter. ❤️ Just wanted to get it done.

@ghost ghost assigned mattr- Dec 26, 2013

@parkr

This comment has been minimized.

Member

parkr commented Dec 26, 2013

Just need @mattr-'s 👀 ❤️

@@ -109,6 +114,11 @@ def initialize(opts = {})
assert_equal "[1,2]", @filter.jsonify([1, 2])
assert_equal "[{\"name\":\"Jack\"},{\"name\":\"Smith\"}]", @filter.jsonify([{:name => 'Jack'}, {:name => 'Smith'}])
end
should "proper filter objects using where" do
assert_equal "some string", @filter.where("some string", nil, nil)

This comment has been minimized.

@mattr-

mattr- Dec 31, 2013

Member

I think this test should be two tests. One to test that the filter works, another to test that no matches in the filter returns the filter input.

@parkr

This comment has been minimized.

Member

parkr commented Jan 4, 2014

Rebased and awaiting your 👀, @mattr- 😃

mattr- added a commit that referenced this pull request Jan 4, 2014

@mattr- mattr- merged commit 7d8c01d into master Jan 4, 2014

1 check passed

default The Travis CI build passed
Details

mattr- added a commit that referenced this pull request Jan 4, 2014

@parkr parkr deleted the benbalter-where-filter branch Jan 4, 2014

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.