Add where filter to filter array objects #1875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Just need @mattr-'s 👀 ❤️ |
| @@ -109,6 +114,11 @@ def initialize(opts = {}) | |||
| assert_equal "[1,2]", @filter.jsonify([1, 2]) | |||
| assert_equal "[{\"name\":\"Jack\"},{\"name\":\"Smith\"}]", @filter.jsonify([{:name => 'Jack'}, {:name => 'Smith'}]) | |||
| end | |||
|
|
|||
| should "proper filter objects using where" do | |||
| assert_equal "some string", @filter.where("some string", nil, nil) | |||
There was a problem hiding this comment.
I think this test should be two tests. One to test that the filter works, another to test that no matches in the filter returns the filter input.
|
Rebased and awaiting your 👀, @mattr- 😃 |
mattr-
added a commit
that referenced
this pull request
Jan 4, 2014
mattr-
added a commit
that referenced
this pull request
Jan 4, 2014
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #1749. Closes #1749.
Along with #1738, fixes #1735.
Output all pages with the layout staff as JSON:
ALL THE PROPS TO @benbalter. ❤️ Just wanted to get it done.