Add a group_by filter. #1738
Closed
Add a group_by filter. #1738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mattr- I think I'm going to need your thoughts on this one. Code could definitely be loads better but my tired mind isn't interested in building it right now. |
|
Also /cc @haacked |
| # {"name" => "larry" | ||
| # "items" => [...] } # all the items where `property` == "larry" | ||
| def group_by(input, property) | ||
| if input.respond_to?(:group_by) |
There was a problem hiding this comment.
perhaps:
if groupable?(input)
where groupable is defined as:
def groupable?(element)
element.respond_to?(:group_by)
end
|
@mattr- Did everything else look OK to you? |
|
I think so. I'll look at it again. |
|
@mattr- Awesome, thanks! Please comment on the weird spots or merge if it's good. :) |
Move jekyllrb.com CSS to includes & Update Normalize.css to v2.1.3
…p-by-filter * 'group-by-filter' of github.com:mojombo/jekyll: Add groupable? method, props @mattr- First (terrible) pass at a group_by filter.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CAUTION: current code is total crap. Don't code tired, kiddies.
#1735