New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert input to string before xml escaping #2244

Merged
merged 4 commits into from Apr 19, 2014

Conversation

Projects
None yet
3 participants
@benbalter
Contributor

benbalter commented Apr 18, 2014

Fixes #2242.

@benbalter benbalter changed the title from convert input to string before xml escaping to Convert input to string before xml escaping Apr 18, 2014

@parkr

This comment has been minimized.

Member

parkr commented Apr 18, 2014

Can you check on the travis build failures? Otherwise LGTM!! :-))))))

@benbalter

This comment has been minimized.

Contributor

benbalter commented Apr 18, 2014

Can you check on the travis build failures?

e91a908

@@ -93,6 +93,10 @@ def initialize(opts = {})
assert_equal "&lt;code&gt;command &amp;lt;filename&amp;gt;&lt;/code&gt;", @filter.xml_escape("<code>command &lt;filename&gt;</code>")
end
should "not error when xml escaping nil" do
assert_equal "", @filter.xml_escape(nil)
ned

This comment has been minimized.

@parkr

This comment has been minimized.

@benbalter

benbalter Apr 19, 2014

Contributor

I prefer it my way 😄

parkr added a commit that referenced this pull request Apr 19, 2014

@parkr parkr merged commit 702d552 into master Apr 19, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@parkr parkr deleted the xml-escape-nil branch Apr 19, 2014

parkr added a commit that referenced this pull request Apr 19, 2014

@parkr

This comment has been minimized.

Member

parkr commented Apr 19, 2014

Thanks @benbalter!

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.