Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add collections to info about pagination support. #2389

Merged
merged 2 commits into from May 21, 2014

Conversation

Projects
None yet
5 participants
@kleinfreund
Copy link
Contributor

kleinfreund commented May 11, 2014

Changing info note in the docs for pagination.

Currently: Pagination does not support tags or categories
Proposed: Pagination does not support tags, categories or collections

Maybe in the future? Related: #2376

Philipp Rudloff
Add collections to info about pagination support.
Currently: _Pagination does not support tags or categories_
Proposed: _Pagination does not support tags, categories or collections_

Maybe in the future? Related: #2376
@mscharley

This comment has been minimized.

Copy link
Contributor

mscharley commented May 11, 2014

Only slightly tongue in cheek, I'd suggest that the built-in pagination
isn't worth much at all.

On 11 May 2014 18:10, Philipp Rudloff notifications@github.com wrote:

Currently: Pagination does not support tags or categories
Proposed: Pagination does not support tags, categories or collections

Maybe in the future? Related: #2376#2376

You can merge this Pull Request by running

git pull https://github.com/kleinfreund/jekyll patch-1

Or view, comment on, or merge it at:

#2389
Commit Summary

  • Add collections to info about pagination support.

File Changes

  • M site/docs/pagination.mdhttps://github.com//pull/2389/files#diff-0(2)

Patch Links:


Reply to this email directly or view it on GitHubhttps://github.com//pull/2389
.

@parkr

This comment has been minimized.

Copy link
Member

parkr commented May 11, 2014

That note is to talk about paginating posts. Talking about paginating posts based on collections is indeed misleading ;) If you can rephrase the body of the paragraph to say that posts won't be paginated based on category and collections are paginated at all?

I'd suggest that the built-in pagination isn't worth much at all.

@mscharley I'd love to split out pagination into a separate plugin. Would you lend a hand to make it even better if that happened?

@kleinfreund

This comment has been minimized.

Copy link
Contributor Author

kleinfreund commented May 11, 2014

@parkr So rather than changing the heading, we should add this information bit to the last sentence? Something like "[...] linked by a common tag, category or collection."

@mscharley

This comment has been minimized.

Copy link
Contributor

mscharley commented May 11, 2014

@parkr I'd consider it, but at the moment my disposable time is
considerably less than I'd hope for normally (just starting a new job,
yay!). We'll see though. Definitely happy to participate in
design/conversations about how to improve it though.

On 12 May 2014 03:07, Philipp Rudloff notifications@github.com wrote:

@parkr https://github.com/parkr So rather than changing the heading, we
should add this information bit to the last sentence? Something like "[...]
linked by a common tag, category or collection."


Reply to this email directly or view it on GitHubhttps://github.com//pull/2389#issuecomment-42776322
.

@parkr

This comment has been minimized.

Copy link
Member

parkr commented May 11, 2014

Something like "[...] linked by a common tag, category or collection."

@kleinfreund This implies that collections are a way of grouping posts, which would be incorrect. It should probably just be a completely separate sentence, saying that pagination is restricted to posts, which means pagination cannot include any collection documents.

my disposable time is considerably less than I'd hope for normally (just starting a new job, yay!)

Congrats on the new job! Totally understand, have to focus on your career. I'll loop you into discussions if/when we create the gem. Thanks! 😃

Philipp Rudloff
Adding to pagination note: Cannot include collections
Adding a sentence to the paragraph to clarify, that pagination is restricted to posts and that it can't contain collections.
@gpxl

This comment has been minimized.

Copy link
Contributor

gpxl commented May 12, 2014

Just to clarify, I was mislead by the following text in the docs.

"Collections allow you to define a new type of document that behave like Pages or Posts do normally"

Given that pages are not grouped pieces of content it would not expect them to paginate, but since collections are I would.

@parkr

This comment has been minimized.

Copy link
Member

parkr commented May 12, 2014

"Collections allow you to define a new type of document that behave like Pages or Posts do normally"

This needs to be rephrased, then. Thanks @gpxl.

parkr added a commit that referenced this pull request May 21, 2014

@parkr parkr merged commit f416c68 into jekyll:master May 21, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

parkr added a commit that referenced this pull request May 21, 2014

@kleinfreund kleinfreund deleted the kleinfreund:patch-1 branch May 21, 2014

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.