-
-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add collections to info about pagination support. #2389
Conversation
Currently: _Pagination does not support tags or categories_ Proposed: _Pagination does not support tags, categories or collections_ Maybe in the future? Related: #2376
Only slightly tongue in cheek, I'd suggest that the built-in pagination On 11 May 2014 18:10, Philipp Rudloff notifications@github.com wrote:
|
That note is to talk about paginating posts. Talking about paginating posts based on collections is indeed misleading ;) If you can rephrase the body of the paragraph to say that posts won't be paginated based on category and collections are paginated at all?
@mscharley I'd love to split out pagination into a separate plugin. Would you lend a hand to make it even better if that happened? |
@parkr So rather than changing the heading, we should add this information bit to the last sentence? Something like "[...] linked by a common tag, category or collection." |
@parkr I'd consider it, but at the moment my disposable time is On 12 May 2014 03:07, Philipp Rudloff notifications@github.com wrote:
|
@kleinfreund This implies that collections are a way of grouping posts, which would be incorrect. It should probably just be a completely separate sentence, saying that pagination is restricted to posts, which means pagination cannot include any collection documents.
Congrats on the new job! Totally understand, have to focus on your career. I'll loop you into discussions if/when we create the gem. Thanks! 😃 |
Adding a sentence to the paragraph to clarify, that pagination is restricted to posts and that it can't contain collections.
Just to clarify, I was mislead by the following text in the docs. "Collections allow you to define a new type of document that behave like Pages or Posts do normally" Given that pages are not grouped pieces of content it would not expect them to paginate, but since collections are I would. |
This needs to be rephrased, then. Thanks @gpxl. |
Changing info note in the docs for pagination.
Currently: Pagination does not support tags or categories
Proposed: Pagination does not support tags, categories or collections
Maybe in the future? Related: #2376