Adds the collection label to a document's data

[budparr]

Related to issue #52 in Jekyll/Jekyll-help this PR adds a document's collection label to its available data.

Forgive the noob, please: I tried adding a test test_document.rb in 'should know its data' and it failed, but I think because of the test, not the change. I ran the addition on a local install and it worked there.

[ct0512]

What can you tell me where you people? Do you think this is much more difficult to repair? I translated it in English to express clear!

[parkr]

@ct0512 Can you please open a new issue describing your problem? Here: https://github.com/jekyll/jekyll/issues/new

[ct0512]

You are?

 Want to know what?

------------------ Original ------------------
From: "notifications";notifications@github.com;
Date: Fri, May 23, 2014 01:24 PM
To: "jekyll/jekyll"jekyll@noreply.github.com;
Cc: "°®ÎÒÄã»áÍ´"laochenmxj@foxmail.com;
Subject: Re: [jekyll] Adds the collection label to a document's data (#2436)

@ct0512 Can you please open a new issue describing your problem? Here: https://github.com/jekyll/jekyll/issues/new

¡ª
Reply to this email directly or view it on GitHub.

[parkr]

@ct0512 I don't understand your problem. Can you please open a new issue: https://github.com/jekyll/jekyll/issues/new

[parkr]

Why not just give the person the whole collection? (via collection.to_liquid)

[budparr]

Sure, but I thought you could derive everything else once you had the label.

[parkr]

I think I'd rather have document.collection.label, just so we know it's the collection label. document.label is a bit confusing to me.

[parkr]

Either that or document.collection is the collection label.

[budparr]

Yeah, I like this too. I'll make the change

On Friday, May 30, 2014, Parker Moore notifications@github.com wrote:

Either that or document.collection is the collection label.

Reply to this email directly or view it on GitHub
#2436 (comment).

Sent from Gmail Mobile

[parkr]

@budparr Once you can get this change in (and the associated test), I'll happily merge.

[budparr]

Hi @parkr - I changed the key to collection from label. I still don't understand how to add the test because I would expect to be able to add it to the existing test for other items now in the to_liquid definition but don't understand how they are done. Apologies for the idiocy!

[parkr]

Extra space here?

[budparr]

fixed, thank you

[parkr]

In terms of adding a test, write another should block in https://github.com/jekyll/jekyll/blob/7a9bc641ee30b5e926f22e39ddd35f94a96562dc/test/test_document.rb:

should "output the collection name in the #to_liquid method" do
  assert_equal @document.to_liquid['collection'], "methods"
end

Make sure it's inside that first context block and you should be good to go!

[budparr]

Thanks, that worked. I was leaving out "['collection']." Really appreciate it - I'm learning!

[parkr]

Thanks, that worked. I was leaving out "['collection']." Really appreciate it - I'm learning!

Yay! Glad it worked out properly. Happy to help 😄