Kramdown use enable_coderay instead of use_coderay for syntax highlighting #3231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hting. By default, Jekyll set use_coderay to false while Kramdown set enable_coderay to true, so Coderay will be always enabled although use_coderay is set false.
| %w[wrap line_numbers line_numbers_start tab_width bold_every css default_lang].each do |opt| | ||
| key = "coderay_#{opt}" | ||
| @config['kramdown'][key] = @config['kramdown']['coderay'][key] unless @config['kramdown'].key?(key) | ||
| end | ||
| else | ||
| @config['kramdown']['enable_coderay'] = false |
There was a problem hiding this comment.
Why not just change the if to enable_coderay?
There was a problem hiding this comment.
Compatibility goes into Configuration – we take the input and ensure the old values have the right keys. My other question is: when did this change in Kramdown?
|
When did this change in Kramdown? |
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, Jekyll set use_coderay to false while Kramdown set enable_coderay to true, so Coderay will be always enabled although use_coderay is set false.
This patch fixed the bug without losing compatibility.
ref: http://kramdown.gettalong.org/options.html