Sunset Maruku #3655

Merged
merged 3 commits into from Apr 14, 2015

Conversation

Projects
None yet
3 participants
@alfredxing
Member

alfredxing commented Apr 14, 2015

Removes Maruku from the Gemfile, removes all references, and removes all Maruku-specific tests.

Also displays the following when markdown: maruku is still specified:

Error: You're using the 'maruku' Markdown processor, which has been removed as of 3.0.0. We recommend you switch to Kramdown. To do this, replace markdown: maruku with markdown: kramdown in your _config.yml file.

Let me know if I missed anything!

Addresses #3098.

@alfredxing

This comment has been minimized.

Show comment
Hide comment
@alfredxing

alfredxing Apr 14, 2015

Member

Hmph. Seems to be an issue with Minitest 5.6.0, which was released today. They messed around with Expectation or something.

Member

alfredxing commented Apr 14, 2015

Hmph. Seems to be an issue with Minitest 5.6.0, which was released today. They messed around with Expectation or something.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Apr 14, 2015

Member

@alfredxing Thanks so much Alfred!!!!!! 🎉 Hope exams are going well. Feel free to rebase on latest master – it now has the locked minitest version. 😄

Member

parkr commented Apr 14, 2015

@alfredxing Thanks so much Alfred!!!!!! 🎉 Hope exams are going well. Feel free to rebase on latest master – it now has the locked minitest version. 😄

@alfredxing

This comment has been minimized.

Show comment
Hide comment
@alfredxing

alfredxing Apr 14, 2015

Member

Rebased and tests passing!

Member

alfredxing commented Apr 14, 2015

Rebased and tests passing!

parkr added a commit that referenced this pull request Apr 14, 2015

@parkr parkr merged commit 7d3a5f8 into jekyll:master Apr 14, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

parkr added a commit that referenced this pull request Apr 14, 2015

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Apr 14, 2015

Member

Terrific!!! Thank you 💓

Member

parkr commented Apr 14, 2015

Terrific!!! Thank you 💓

@parkr parkr added this to the 3.0 milestone Apr 14, 2015

@alfredxing alfredxing deleted the alfredxing:sunset-maruku branch Apr 14, 2015

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.