Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ssl support add serve tests #3792

Closed
wants to merge 1 commit into from
Closed

Add ssl support add serve tests #3792

wants to merge 1 commit into from

Conversation

envygeeks
Copy link
Contributor

/cc @parkr @jekyll/core

@envygeeks envygeeks force-pushed the add-ssl-support-add-serve-tests branch from 99bb06a to 1ba328b Compare June 17, 2015 03:32
parkr
parkr reviewed Jul 1, 2015
View reviewed changes
lib/jekyll/commands/serve.rb
class << self
COMMAND_OPTIONS = {
"detact" => ["-B", "--detach", "Run the server in the background (detach)"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/detact/detach/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's been fixed locally I should probably push up the new changes with the new handler.

@parkr
Copy link
Member

parkr commented Jul 1, 2015

No substantive questions here, all style fixes. Thanks, Jordon!

parkr
parkr reviewed Jul 1, 2015
View reviewed changes
lib/jekyll/commands/serve.rb
WEBrick::HTTPUtils::load_mime_types(mime_types_file)
WEBrick::HTTPUtils::load_mime_types(
mime_types_file
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can be on one line.

@parkr
Copy link
Member

parkr commented Jul 2, 2015

/cc #3478.

@alfredxing
Copy link
Member

👍

SSL support is good in general but I really don't want to act like we are promoting running this as a production server 😉

@envygeeks envygeeks force-pushed the add-ssl-support-add-serve-tests branch from 1ba328b to 931c3b1 Compare July 16, 2015 19:00
@parkr
Copy link
Member

parkr commented Sep 21, 2015

How's this PR doing? Why do we want SSL for local testing, again?

@envygeeks
Copy link
Contributor Author

The SSL was for somebody who requested SSL because they were working with API's that required SSL and stuff like that, it's a good idea to allow it just in-case. I'll work on getting it cleaned up to get merged tomorrow morning since I have time.

@envygeeks envygeeks added this to the 3.1 milestone Dec 4, 2015
@envygeeks envygeeks self-assigned this Dec 4, 2015
@envygeeks envygeeks force-pushed the add-ssl-support-add-serve-tests branch from 931c3b1 to 29238fb Compare December 4, 2015 17:40
Fix #3791/#3478
1071cd4 
* Add support for custom-headers through configuration
* Add support for SSL through command line switches.
* Add a few basic tests (more to come as I figure it out.)
@envygeeks envygeeks force-pushed the add-ssl-support-add-serve-tests branch from 29238fb to 1071cd4 Compare December 4, 2015 17:41
@envygeeks
Copy link
Contributor Author

I'm gonna drop this pull and merge two pulls I have open with the same file into a single pull. Plus this rebase messed everything up and I'm in no mood to fight with Git, I've a lot of Jekyll stuff planned for today.

@envygeeks envygeeks closed this Dec 4, 2015
@envygeeks envygeeks removed this from the 3.1 milestone Dec 4, 2015
@envygeeks envygeeks removed their assignment Dec 4, 2015
@parkr parkr deleted the add-ssl-support-add-serve-tests branch December 4, 2015 17:54
@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
frozen-due-to-age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@envygeeks @parkr @alfredxing @mattr- @jekyllbot