Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the formatting #3940

Closed
wants to merge 1 commit into from
Closed

Fix the formatting #3940

wants to merge 1 commit into from

Conversation

chrisfinazzo
Copy link
Contributor

No description provided.

@envygeeks
Copy link
Contributor

I don't think this fixes anything, but I do think that it makes the formatting feel off.

@envygeeks
Copy link
Contributor

I guess it would be fine if they weren't forced onto their own line, otherwise it should be a block like it was, unless it was an accident it was made a single grave instead of triple.

@parkr
Copy link
Member

parkr commented Aug 27, 2015

I like the way the 4-space indents give these lines a significance and separation that is easier on the eye and the brain. Thanks for the contribution, but I think I'm going to leave it as is. 👍

@parkr parkr closed this Aug 27, 2015
@parkr
Copy link
Member

parkr commented Aug 27, 2015

The style could use an update tho to add the backdrop:

screen shot 2015-08-27 at 1 25 54 pm

@chrisfinazzo
Copy link
Contributor Author

@parkr, that's what I was getting at, for whatever reason these were not indented properly. I'll look at master again to see what's actually going on (my local branch has obviously diverged from this).

@chrisfinazzo
Copy link
Contributor Author

Huh, indented by 4 spaces and...nothing. No text styles whatsoever. 😒

@envygeeks
Copy link
Contributor

That's because 4 spaces and triple grave are treated different than {% highlight %} but you can't use {% highlight %} on that document because it's actually meant for Github (it's linked through by every ticket creation to nag you to follow the rules)

@parkr
Copy link
Member

parkr commented Aug 27, 2015

@chrisfinazzo Our Markdown converter should add a <pre> – maybe we can add the style to that on this page?

@envygeeks
Copy link
Contributor

@envygeeks
Copy link
Contributor

With only the <figure> the rest of it is already created.

@chrisfinazzo chrisfinazzo deleted the format-code-correctly branch September 8, 2015 01:06
@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants