New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing rubocop offenses in lib/jekyll/cleaner.rb #4892

Merged
merged 1 commit into from May 13, 2016

Conversation

Projects
None yet
4 participants
@derekgottlieb
Contributor

derekgottlieb commented May 13, 2016

No description provided.

@parkr parkr changed the title from Fixing rubocop offenses in lib/jekyll/cleaner.rb per issue #4885 to Fixing rubocop offenses in lib/jekyll/cleaner.rb May 13, 2016

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr May 13, 2016

Member

Thank you so much! 😍

@jekyllbot: merge +dev

Member

parkr commented May 13, 2016

Thank you so much! 😍

@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit 6dc9665 into jekyll:master May 13, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

jekyllbot added a commit that referenced this pull request May 13, 2016

@parkr parkr referenced this pull request May 13, 2016

Closed

Make jekyll/jekyll code compliant with rubocop rules #4885

114 of 115 tasks complete
@derekgottlieb

This comment has been minimized.

Show comment
Hide comment
@derekgottlieb

derekgottlieb May 13, 2016

Contributor

If I cleaned up some more of these, would you prefer a PR per file or a PR for several of them?

Contributor

derekgottlieb commented May 13, 2016

If I cleaned up some more of these, would you prefer a PR per file or a PR for several of them?

@derekgottlieb derekgottlieb deleted the derekgottlieb:rubocop-cleaner branch May 13, 2016

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks May 13, 2016

Contributor

A single PR with multiple and a commit for each file would be preferable for cleanliness.

Contributor

envygeeks commented May 13, 2016

A single PR with multiple and a commit for each file would be preferable for cleanliness.

@derekgottlieb

This comment has been minimized.

Show comment
Hide comment
@derekgottlieb

derekgottlieb May 13, 2016

Contributor

Can do!

Contributor

derekgottlieb commented May 13, 2016

Can do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment