-
-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rubocop: converters #4931
Rubocop: converters #4931
Conversation
@@ -17,19 +18,20 @@ def block_code(code, lang) | |||
Jekyll::External.require_with_graceful_fail("pygments") | |||
lang = lang && lang.split.first || "text" | |||
add_code_tags( | |||
Pygments.highlight(code, :lexer => lang, :options => { :encoding => 'utf-8' }), | |||
Pygments.highlight(code, :lexer => lang, :options => \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should just be split up into a multiline hash.
Thanks! Just a few comments. |
end | ||
def convert(content) | ||
@redcarpet_extensions[:fenced_code_blocks] = \ | ||
!@redcarpet_extensions[:no_fenced_code_blocks] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without breaking this up, the line is 97 characters instead of 90 😕
lib/jekyll/converters
@envygeeks Is there a reason |
markdown.render(content) | ||
def convert(content) | ||
@redcarpet_extensions[:fenced_code_blocks] = \ | ||
!@redcarpet_extensions[:no_fenced_code_blocks] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would be 99 characters if it was all on one line.
Wheeeee another one!!! Thank you!!! @jekyllbot: merge +dev |
No description provided.