-
-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix rubocop offenses in exe/jekyll #5017
Conversation
@@ -3,31 +3,35 @@ STDOUT.sync = true | |||
|
|||
$LOAD_PATH.unshift File.join(File.dirname(__FILE__), *%w( .. lib )) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
()
is necessary please!
Thanks! Juts a comment. |
p.syntax "jekyll <subcommand> [options]" | ||
|
||
p.option "source", "-s", "--source [DIR]", "Source directory (defaults to ./)" | ||
p.option "destination", "-d", "--destination [DIR]", \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the trailing \
's necessary here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They aren't, in Ruby they are only necessary in ambiguous situations.
Thank you! ❤️ @jekyllbot: merge +dev |
❤️ |
#4885