Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use activesupport < 5 if we are on a Ruby < 2.2.2 #5100

Merged
merged 1 commit into from Jul 13, 2016
Merged

use activesupport < 5 if we are on a Ruby < 2.2.2 #5100

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions Gemfile
View file
Open in desktop
Expand Up @@ -2,6 +2,9 @@ source "https://rubygems.org"
gemspec :name => "jekyll"

gem "rake", "~> 11.0"

gem "activesupport", "~> 4.2", :groups => [:test_legacy, :site] if RUBY_ENGINE == 'ruby' && RUBY_VERSION < '2.2.2'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is RUBY_ENGINE necessary here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@parkr Good question, i used Rails' ruby_version_check.rb as an example but could be possible to leave it out i guess.


group :development do
gem "launchy", "~> 2.3"
gem "pry"
Expand Down