New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: move permalinks from documents into config #5544

Merged
merged 5 commits into from Jan 8, 2017

Conversation

Projects
None yet
4 participants
@parkr
Member

parkr commented Nov 3, 2016

Reverts jekyll/jekyll#5532 in favor of a global permalink 馃槃

@parkr parkr changed the title from Revert "Add permalinks to docs in '/maintaining/'" to Docs: move permalinks from documents into config Nov 3, 2016

@parkr parkr added the documentation label Nov 3, 2016

@parkr

This comment has been minimized.

Show comment
Hide comment
Member

parkr commented Nov 3, 2016

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Nov 3, 2016

Member

script/proof with --disable-external:

- ./_site/docs/maintaining/becoming-a-maintainer/index.html
  *  internally linking to reviewing-a-pull-request.md, which does not exist (line 311)
  *  internally linking to triaging-an-issue.md, which does not exist (line 299)
- ./_site/docs/maintaining/merging-a-pull-request/index.html
  *  internally linking to reviewing-a-pull-request.md, which does not exist (line 295)
- ./_site/docs/maintaining/reviewing-a-pull-request/index.html
  *  internally linking to ../CONDUCT.markdown, which does not exist (line 293)
- ./_site/docs/maintaining/special-labels/index.html
  *  internally linking to triaging-an-issue.md#staleness-and-automatic-closure, which does not exist (line 305)
  *  trying to find hash of triaging-an-issue.md#staleness-and-automatic-closure, but /Users/parkr/jekyll/jekyll/_site/docs/maintaining/special-labels/index.html/triaging-an-issue.md does not exist (line 305)
htmlproof 2.6.4 | Error:  HTML-Proofer found 6 failures!

Gonna fix those here too.

Member

parkr commented Nov 3, 2016

script/proof with --disable-external:

- ./_site/docs/maintaining/becoming-a-maintainer/index.html
  *  internally linking to reviewing-a-pull-request.md, which does not exist (line 311)
  *  internally linking to triaging-an-issue.md, which does not exist (line 299)
- ./_site/docs/maintaining/merging-a-pull-request/index.html
  *  internally linking to reviewing-a-pull-request.md, which does not exist (line 295)
- ./_site/docs/maintaining/reviewing-a-pull-request/index.html
  *  internally linking to ../CONDUCT.markdown, which does not exist (line 293)
- ./_site/docs/maintaining/special-labels/index.html
  *  internally linking to triaging-an-issue.md#staleness-and-automatic-closure, which does not exist (line 305)
  *  trying to find hash of triaging-an-issue.md#staleness-and-automatic-closure, but /Users/parkr/jekyll/jekyll/_site/docs/maintaining/special-labels/index.html/triaging-an-issue.md does not exist (line 305)
htmlproof 2.6.4 | Error:  HTML-Proofer found 6 failures!

Gonna fix those here too.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Nov 3, 2016

Member

Welp. 7af4164

Member

parkr commented Nov 3, 2016

Welp. 7af4164

appease script/proof --disable-external
appease script/proof --disable-external
@zdroid

This comment has been minimized.

Show comment
Hide comment
@zdroid

zdroid Nov 10, 2016

Member

Seems fine to me. Just gotta resolve merge issues.

Member

zdroid commented Nov 10, 2016

Seems fine to me. Just gotta resolve merge issues.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Nov 10, 2016

Member

oh @DirtyF did you already fix these?

Member

parkr commented Nov 10, 2016

oh @DirtyF did you already fix these?

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Nov 10, 2016

Member

@parkr yes, everything was OK yesterday, the remaining conflict is just about a link I add in a page. Feel free to review it on your machine.

Member

DirtyF commented Nov 10, 2016

@parkr yes, everything was OK yesterday, the remaining conflict is just about a link I add in a page. Feel free to review it on your machine.

@DirtyF

DirtyF approved these changes Jan 8, 2017

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Jan 8, 2017

Member

@jekyllbot: merge +site

Member

DirtyF commented Jan 8, 2017

@jekyllbot: merge +site

@DirtyF DirtyF closed this Jan 8, 2017

@jekyllbot jekyllbot merged commit 60a2396 into master Jan 8, 2017

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@jekyllbot jekyllbot deleted the revert-5532-perma-docs branch Jan 8, 2017

jekyllbot added a commit that referenced this pull request Jan 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment