Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: move permalinks from documents into config #5544

Merged
merged 5 commits into from
Jan 8, 2017

Conversation

parkr
Copy link
Member

@parkr parkr commented Nov 3, 2016

Reverts #5532 in favor of a global permalink 馃槃

@parkr parkr changed the title Revert "Add permalinks to docs in '/maintaining/'" Docs: move permalinks from documents into config Nov 3, 2016
@parkr
Copy link
Member Author

parkr commented Nov 3, 2016

/cc @jekyll/documentation

@parkr
Copy link
Member Author

parkr commented Nov 3, 2016

script/proof with --disable-external:

- ./_site/docs/maintaining/becoming-a-maintainer/index.html
  *  internally linking to reviewing-a-pull-request.md, which does not exist (line 311)
  *  internally linking to triaging-an-issue.md, which does not exist (line 299)
- ./_site/docs/maintaining/merging-a-pull-request/index.html
  *  internally linking to reviewing-a-pull-request.md, which does not exist (line 295)
- ./_site/docs/maintaining/reviewing-a-pull-request/index.html
  *  internally linking to ../CONDUCT.markdown, which does not exist (line 293)
- ./_site/docs/maintaining/special-labels/index.html
  *  internally linking to triaging-an-issue.md#staleness-and-automatic-closure, which does not exist (line 305)
  *  trying to find hash of triaging-an-issue.md#staleness-and-automatic-closure, but /Users/parkr/jekyll/jekyll/_site/docs/maintaining/special-labels/index.html/triaging-an-issue.md does not exist (line 305)
htmlproof 2.6.4 | Error:  HTML-Proofer found 6 failures!

Gonna fix those here too.

@parkr
Copy link
Member Author

parkr commented Nov 3, 2016

Welp. 7af4164

appease script/proof --disable-external
@zlatanvasovic
Copy link
Contributor

Seems fine to me. Just gotta resolve merge issues.

@parkr
Copy link
Member Author

parkr commented Nov 10, 2016

oh @DirtyF did you already fix these?

@DirtyF
Copy link
Member

DirtyF commented Nov 10, 2016

@parkr yes, everything was OK yesterday, the remaining conflict is just about a link I add in a page. Feel free to review it on your machine.

@DirtyF
Copy link
Member

DirtyF commented Jan 8, 2017

@jekyllbot: merge +site

@DirtyF DirtyF closed this Jan 8, 2017
@jekyllbot jekyllbot merged commit 60a2396 into master Jan 8, 2017
@jekyllbot jekyllbot deleted the revert-5532-perma-docs branch January 8, 2017 12:50
jekyllbot added a commit that referenced this pull request Jan 8, 2017
@jekyll jekyll locked and limited conversation to collaborators Jul 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants