New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve theme docs #5690

Merged
merged 6 commits into from Jan 24, 2017

Conversation

Projects
None yet
6 participants
@tomjoht
Contributor

tomjoht commented Dec 26, 2016

See #5630 for more details on the update.

@jekyll/documentation

Improve theme docs
See #5630 for more details on the update. 

@jekyll/documentation
@DirtyF
Show outdated Hide outdated docs/_docs/themes.md
title: Themes
permalink: /docs/themes/
title: Templates
permalink: /docs/templates/

This comment has been minimized.

@pathawks

pathawks Dec 26, 2016

Member

Woah. Let's not break all existing links.

@pathawks

pathawks Dec 26, 2016

Member

Woah. Let's not break all existing links.

This comment has been minimized.

@tomjoht

tomjoht Dec 26, 2016

Contributor

I had actually pasted in the wrong page here. Thanks for catching this.

@tomjoht

tomjoht Dec 26, 2016

Contributor

I had actually pasted in the wrong page here. Thanks for catching this.

Updated to correct content
I previously had pasted in the wrong page here. Now it's fixed.
@DirtyF

Just a few comments

Show outdated Hide outdated docs/_docs/themes.md
## Using themes other than the default {#installing-a-theme}
The `jekyll new <PATH>` command isn't the only way to create a new Jekyll site with a gem-based theme. You can also find gem-based themes online and incorporate them into your Jekyll project. To install a gem-based theme:

This comment has been minimized.

@DirtyF

DirtyF Dec 26, 2016

Member

We could link to https://rubygems.org/search?utf8=%E2%9C%93&query=jekyll-theme to show other themes packaged as gems.

@DirtyF

DirtyF Dec 26, 2016

Member

We could link to https://rubygems.org/search?utf8=%E2%9C%93&query=jekyll-theme to show other themes packaged as gems.

This comment has been minimized.

@ashmaroli

ashmaroli Dec 26, 2016

Member

But note that not all gem-based jekyll themes are named using that convention..

@ashmaroli

ashmaroli Dec 26, 2016

Member

But note that not all gem-based jekyll themes are named using that convention..

This comment has been minimized.

@pathawks

pathawks Dec 26, 2016

Member

Until we get the theme registry setup, we could link to the page showing all the themes whitelisted for GitHub Pages

@pathawks

pathawks Dec 26, 2016

Member

Until we get the theme registry setup, we could link to the page showing all the themes whitelisted for GitHub Pages

This comment has been minimized.

@DirtyF

DirtyF Dec 26, 2016

Member

The idea was to show people that there were some gem-based themes outside of the limited number whitelisted by GitHub 😕

@DirtyF

DirtyF Dec 26, 2016

Member

The idea was to show people that there were some gem-based themes outside of the limited number whitelisted by GitHub 😕

This comment has been minimized.

@pathawks

pathawks Dec 26, 2016

Member

👍

@pathawks

This comment has been minimized.

@tomjoht

tomjoht Dec 27, 2016

Contributor

i added a link in parentheses. i was unaware of the "jekyll-theme" naming style in RubyGems. Even if it's not comprehensive, it's better than nothing.

@tomjoht

tomjoht Dec 27, 2016

Contributor

i added a link in parentheses. i was unaware of the "jekyll-theme" naming style in RubyGems. Even if it's not comprehensive, it's better than nothing.

Show outdated Hide outdated docs/_docs/themes.md
If you're publishing your Jekyll site on [Github Pages](https://pages.github.com/), note that Github Pages supports only some gem-based themes. See [Supported Themes](https://pages.github.com/themes/) in Github's documentation to see which themes are supported.
## Creating your own gem-based theme

This comment has been minimized.

@DirtyF

DirtyF Dec 26, 2016

Member

-> Creating a gem-based theme

@DirtyF

DirtyF Dec 26, 2016

Member

-> Creating a gem-based theme

This comment has been minimized.

@tomjoht

tomjoht Dec 27, 2016

Contributor

updated

@tomjoht

tomjoht Dec 27, 2016

Contributor

updated

Show outdated Hide outdated docs/_docs/themes.md
Now `bundle update` will no longer get updates for the theme gem.
## Using themes other than the default {#installing-a-theme}

This comment has been minimized.

@DirtyF

DirtyF Dec 26, 2016

Member

-> Installing a gem-based theme

@DirtyF

DirtyF Dec 26, 2016

Member

-> Installing a gem-based theme

This comment has been minimized.

@tomjoht

tomjoht Dec 27, 2016

Contributor

updated

@tomjoht

tomjoht Dec 27, 2016

Contributor

updated

Show outdated Hide outdated docs/_docs/themes.md
### Stylesheets
Your theme's stylesheets should be placed in your theme's `/_sass` folder, again, just as you would when authoring a Jekyll site. Your theme's styles can be included in the user's stylesheet using the `@import` directive.

This comment has been minimized.

@DirtyF

DirtyF Dec 26, 2016

Member

Shouldn't we show an example here? Should we imply a convention like prefixing the gem with jekyll-theme-?

Your theme's stylesheets should be placed in your theme's /_sass folder, again, just as you would when authoring a Jekyll site.

  _sass
├── jekyll-theme-my-awesome-theme.scss

Your theme's styles can be included in the user's stylesheet using the @import directive.

@import "{{ site.theme }}";

@DirtyF

DirtyF Dec 26, 2016

Member

Shouldn't we show an example here? Should we imply a convention like prefixing the gem with jekyll-theme-?

Your theme's stylesheets should be placed in your theme's /_sass folder, again, just as you would when authoring a Jekyll site.

  _sass
├── jekyll-theme-my-awesome-theme.scss

Your theme's styles can be included in the user's stylesheet using the @import directive.

@import "{{ site.theme }}";

This comment has been minimized.

@tomjoht

tomjoht Dec 27, 2016

Contributor

i made the update. (Note, however, that I didn't actually make any updates to that section. It was there previously.) I did just make the long paragraph a little more readable.

@tomjoht

tomjoht Dec 27, 2016

Contributor

i made the update. (Note, however, that I didn't actually make any updates to that section. It was there previously.) I did just make the long paragraph a little more readable.

Show outdated Hide outdated docs/_docs/themes.md
@@ -71,7 +137,7 @@ For example, if your theme has a `/_layouts/page.html` file, and a page has `lay
### Assets
Any file in `/assets` will be copied over to the user's site upon build unless they have a file with the same relative path. You may ship any kind of asset here: SCSS, an image, a webfont, etc. These files behave just like pages and static files in Jekyll: if the file has [YAML front matter]({{ site.baseurl }}/docs/frontmatter/) at the top, then it will be rendered. If it does not have YAML front matter, it will simply be copied over into the resulting site. This allows theme creators to ship a default `/assets/styles.scss` file which their layouts can depend on as `/assets/styles.css`.
Any file in `/assets` will be copied over to the user's site upon build unless they have a file with the same relative path. You can ship any kind of asset here: SCSS, an image, a webfont, etc. These files behave just like pages and static files in Jekyll: if the file has [YAML front matter](../docs/frontmatter/) at the top, then it will be rendered. If it does not have YAML front matter, it will simply be copied over into the resulting site. This allows theme creators to ship a default `/assets/styles.scss` file which their layouts can depend on as `/assets/styles.css`.

This comment has been minimized.

@DirtyF

DirtyF Dec 26, 2016

Member

The correct internal link is [YAML front matter](../frontmatter/)

@DirtyF

DirtyF Dec 26, 2016

Member

The correct internal link is [YAML front matter](../frontmatter/)

This comment has been minimized.

@tomjoht

tomjoht Dec 27, 2016

Contributor

updated

@tomjoht

tomjoht Dec 27, 2016

Contributor

updated

Show outdated Hide outdated docs/_docs/themes.md
1. To install a theme, first, add the theme to your site's `Gemfile`:
When you [create a new Jekyll site](/docs/quickstart) (by running the `jekyll new <PATH>` command), Jekyll installs a gem-based theme called [Minima](https://github.com/jekyll/minima).

This comment has been minimized.

@ashmaroli

ashmaroli Dec 26, 2016

Member
- Jekyll installs a gem-based theme called [Minima](https://github.com/jekyll/minima).
+ Jekyll installs a Site that uses a gem-based theme called [Minima](https://github.com/jekyll/minima).
@ashmaroli

ashmaroli Dec 26, 2016

Member
- Jekyll installs a gem-based theme called [Minima](https://github.com/jekyll/minima).
+ Jekyll installs a Site that uses a gem-based theme called [Minima](https://github.com/jekyll/minima).

This comment has been minimized.

@tomjoht

tomjoht Dec 27, 2016

Contributor

updated, but why capitalize "site" here?

@tomjoht

tomjoht Dec 27, 2016

Contributor

updated, but why capitalize "site" here?

This comment has been minimized.

@ashmaroli

ashmaroli Dec 27, 2016

Member

no particular reason. site is just as valid as Site in this context

@ashmaroli

ashmaroli Dec 27, 2016

Member

no particular reason. site is just as valid as Site in this context

Show outdated Hide outdated docs/_docs/themes.md
gem 'my-awesome-jekyll-theme'
With gem-based themes, some of the theme directories and files are stored in the gem, hidden from view in your Jekyll project. As a result, the files and directories shown for your site are only part of all the theme's files. In the case of Minima, you see only the following:

This comment has been minimized.

@ashmaroli

ashmaroli Dec 26, 2016

Member
- With gem-based themes, some of the theme directories and files are stored in the gem, hidden from view in your Jekyll project. As a result, the files and directories shown for your site are only part of all the theme's files.
+ With gem-based themes, some of the site's directories and files are stored in the theme-gem, hidden from your immediate view. Yet, all of the necessary directories will be read and processed during Jekyll's build process.
@ashmaroli

ashmaroli Dec 26, 2016

Member
- With gem-based themes, some of the theme directories and files are stored in the gem, hidden from view in your Jekyll project. As a result, the files and directories shown for your site are only part of all the theme's files.
+ With gem-based themes, some of the site's directories and files are stored in the theme-gem, hidden from your immediate view. Yet, all of the necessary directories will be read and processed during Jekyll's build process.

This comment has been minimized.

@tomjoht

tomjoht Dec 27, 2016

Contributor

updated. (but had to fix the flow given the addition.)

@tomjoht

tomjoht Dec 27, 2016

Contributor

updated. (but had to fix the flow given the addition.)

Show outdated Hide outdated docs/_docs/themes.md
With a clear understanding of the theme's files, you can now override any theme file by creating a similarly named file in your Jekyll site directory.
If you want to get rid of the theme gem altogether, copy the files from the theme gem's directory into your Jekyll site directory (for example, copy them to `/myblog` if you created your Jekyll site at `/myblog`).

This comment has been minimized.

@ashmaroli

ashmaroli Dec 26, 2016

Member

Think it would be better to have this and following paras under a sub-heading: Stop using Gem-based themes

@ashmaroli

ashmaroli Dec 26, 2016

Member

Think it would be better to have this and following paras under a sub-heading: Stop using Gem-based themes

This comment has been minimized.

@tomjoht

tomjoht Dec 27, 2016

Contributor

updated

@tomjoht

tomjoht Dec 27, 2016

Contributor

updated

Show outdated Hide outdated docs/_docs/themes.md
## Using themes other than the default {#installing-a-theme}
The `jekyll new <PATH>` command isn't the only way to create a new Jekyll site with a gem-based theme. You can also find gem-based themes online and incorporate them into your Jekyll project. To install a gem-based theme:

This comment has been minimized.

@ashmaroli

ashmaroli Dec 26, 2016

Member

But note that not all gem-based jekyll themes are named using that convention..

@ashmaroli

ashmaroli Dec 26, 2016

Member

But note that not all gem-based jekyll themes are named using that convention..

Show outdated Hide outdated docs/_docs/themes.md
The `jekyll new <PATH>` command isn't the only way to create a new Jekyll site with a gem-based theme. You can also find gem-based themes online and incorporate them into your Jekyll project. To install a gem-based theme:
1. Add the theme to your site's `Gemfile`:

This comment has been minimized.

@ashmaroli

ashmaroli Dec 26, 2016

Member

this clear line before the start of a fenced-code block is not needed actually..

@ashmaroli

ashmaroli Dec 26, 2016

Member

this clear line before the start of a fenced-code block is not needed actually..

This comment has been minimized.

@tomjoht

tomjoht Dec 27, 2016

Contributor

i see. i thought it was needed. however, without it, the spacing seems too smushed together.

@tomjoht

tomjoht Dec 27, 2016

Contributor

i see. i thought it was needed. however, without it, the spacing seems too smushed together.

Show outdated Hide outdated docs/_docs/themes.md
gem 'my-awesome-jekyll-theme'
```
3. Install the theme:

This comment has been minimized.

@ashmaroli

ashmaroli Dec 26, 2016

Member

continuity-error: 1 is followed by 3, then again by 3, then a 5...

@ashmaroli

ashmaroli Dec 26, 2016

Member

continuity-error: 1 is followed by 3, then again by 3, then a 5...

This comment has been minimized.

@tomjoht

tomjoht Dec 27, 2016

Contributor

fixed

@tomjoht

tomjoht Dec 27, 2016

Contributor

fixed

Show outdated Hide outdated docs/_docs/themes.md
Jekyll themes are distributed as Ruby gems. Don't worry, Jekyll will help you scaffold a new theme with the `new-theme` command. Just run `jekyll new-theme` with the theme name as an argument:
If you're unfamiliar with distributing ruby gems, don't worry. Jekyll will help you scaffold a new theme with the `new-theme` command. Just run `jekyll new-theme` with the theme name as an argument:

This comment has been minimized.

@ashmaroli

ashmaroli Dec 26, 2016

Member

This section had some changes requested in the previous PR..

@ashmaroli

ashmaroli Dec 26, 2016

Member

This section had some changes requested in the previous PR..

This comment has been minimized.

@tomjoht

tomjoht Dec 27, 2016

Contributor

Pathawkes had said:

Scaffolding a new theme is unrelated to distributing Ruby gems. This is not one sentence

Also, you wrote:

you can package up your theme as ruby gems

Actually, I don't really mean to make controversial changes here. My main changes were in another part of this file. But I made an update to this paragraph just now to change "distributing" to "creating" and also capitalized "Ruby." Isn't Ruby capitalized, just as Java, Python, or other programming languages?

Also, the phrase "don't worry" is short enough to stand on its own.

@tomjoht

tomjoht Dec 27, 2016

Contributor

Pathawkes had said:

Scaffolding a new theme is unrelated to distributing Ruby gems. This is not one sentence

Also, you wrote:

you can package up your theme as ruby gems

Actually, I don't really mean to make controversial changes here. My main changes were in another part of this file. But I made an update to this paragraph just now to change "distributing" to "creating" and also capitalized "Ruby." Isn't Ruby capitalized, just as Java, Python, or other programming languages?

Also, the phrase "don't worry" is short enough to stand on its own.

This comment has been minimized.

@ashmaroli

ashmaroli Dec 27, 2016

Member

yes Ruby should be capitalized 👍

@ashmaroli

ashmaroli Dec 27, 2016

Member

yes Ruby should be capitalized 👍

Made updates requested by others in PR
I made various updates as requested by the reviewers.
@tomjoht

This comment has been minimized.

Show comment
Hide comment
@tomjoht

tomjoht Dec 27, 2016

Contributor

I made all the requested updates to this topic. Submitting for re-review.

Contributor

tomjoht commented Dec 27, 2016

I made all the requested updates to this topic. Submitting for re-review.

Your theme's styles can be included in the user's stylesheet using the `@import` directive.
```css
{% raw %}@import "{{ site.theme }}";{% endraw %}

This comment has been minimized.

@ashmaroli

ashmaroli Dec 27, 2016

Member

while I'm 👍 on the use of @import "{{ site.theme }}";, lets hope it doesn't create confusion or an extra step of customization for people opting to not using gem-based themes or in the rare situation that the theme-gem doesn't name their main sass file the same as their theme-name..

@ashmaroli

ashmaroli Dec 27, 2016

Member

while I'm 👍 on the use of @import "{{ site.theme }}";, lets hope it doesn't create confusion or an extra step of customization for people opting to not using gem-based themes or in the rare situation that the theme-gem doesn't name their main sass file the same as their theme-name..

@DirtyF

DirtyF approved these changes Dec 28, 2016

❤️ Great addition to the docs. We can merge this and improve in further PRs.

Show outdated Hide outdated docs/_docs/themes.md
bundle install
```
3. Add the following to your site's `_config.yml` to activate the theme:

This comment has been minimized.

@DirtyF

DirtyF Dec 28, 2016

Member

Missing space at the beginning of the third list item.

code-rendering

@DirtyF

DirtyF Dec 28, 2016

Member

Missing space at the beginning of the third list item.

code-rendering

@parkr

Thanks! Just a few comments.

Show outdated Hide outdated docs/_docs/themes.md
Jekyll will look first to your site's content, before looking to the theme's defaults, for any requested file in the following folders:
For example, if your selected theme has a `page` layout, you can override the theme's layout by creating your own `page` layout in the `_layouts` directory (for example, `_layouts/page.html`).

This comment has been minimized.

@parkr

parkr Dec 29, 2016

Member

(for example, _layouts/page.html)

This is a tricky case of "e.g." vs "i.e." and I think it's "i.e." here, because you're elaborating and giving specific information about a pre-existing example. This would read better to me:

by creating your own page layout in the _layouts directory, i.e. _layouts/page.html.

Feel free to replace "i.e." with something less Latin if you would prefer.

@parkr

parkr Dec 29, 2016

Member

(for example, _layouts/page.html)

This is a tricky case of "e.g." vs "i.e." and I think it's "i.e." here, because you're elaborating and giving specific information about a pre-existing example. This would read better to me:

by creating your own page layout in the _layouts directory, i.e. _layouts/page.html.

Feel free to replace "i.e." with something less Latin if you would prefer.

This comment has been minimized.

@tomjoht

tomjoht Dec 29, 2016

Contributor

updated.

@tomjoht

tomjoht Dec 29, 2016

Contributor

updated.

Show outdated Hide outdated docs/_docs/themes.md
1. Run `bundle show` followed by the name of the theme's gem, e.g., `bundle show minima` for default Jekyll's theme.
The location of the theme gem is returned. For example, minima is located in `/usr/local/lib/ruby/gems/2.3.0/gems/minima-2.1.0` on a Mac.

This comment has been minimized.

@parkr

parkr Dec 29, 2016

Member

This path is not always the path on a Mac, so I'd love to see some specificity here for our users:

is located in /usr/local/lib/ruby/gems/2.3.0/gems/minima-2.1.0 when using the system Ruby installation on a Mac.

@parkr

parkr Dec 29, 2016

Member

This path is not always the path on a Mac, so I'd love to see some specificity here for our users:

is located in /usr/local/lib/ruby/gems/2.3.0/gems/minima-2.1.0 when using the system Ruby installation on a Mac.

This comment has been minimized.

@tomjoht

tomjoht Dec 29, 2016

Contributor

updated

@tomjoht

tomjoht Dec 29, 2016

Contributor

updated

Show outdated Hide outdated docs/_docs/themes.md
```
cd /usr/local/lib/ruby/gems/2.3.0/gems/minima-2.1.0
open .
# for Windows, use "explorer ."

This comment has been minimized.

@parkr

parkr Dec 29, 2016

Member

Why not open /usr/local/lib/ruby/gems/2.3.0/gems/minima-2.1.0?

@parkr

parkr Dec 29, 2016

Member

Why not open /usr/local/lib/ruby/gems/2.3.0/gems/minima-2.1.0?

This comment has been minimized.

@tomjoht

tomjoht Dec 29, 2016

Contributor

"open" doesn't work on the Windows command terminal (at least not mine, and I have a Windows 10 PC. "explorer" does work, though.

@tomjoht

tomjoht Dec 29, 2016

Contributor

"open" doesn't work on the Windows command terminal (at least not mine, and I have a Windows 10 PC. "explorer" does work, though.

This comment has been minimized.

@DirtyF

DirtyF Jan 8, 2017

Member

added examples for each OS.

On MacOS you can simply open $(bundle show minima), I leaved the full path with explorer command as I have no clue if that works under Windows.

@DirtyF

DirtyF Jan 8, 2017

Member

added examples for each OS.

On MacOS you can simply open $(bundle show minima), I leaved the full path with explorer command as I have no clue if that works under Windows.

Show outdated Hide outdated docs/_docs/themes.md
A Finder or Explorer window opens showing the theme's files and directories.
With a clear understanding of the theme's files, you can now override any theme file by creating a similarly named file in your Jekyll site directory.

This comment has been minimized.

@parkr

parkr Dec 29, 2016

Member

Perhaps an example here would be useful. The user may still be wondering what the full path is they need to create in their site.

@parkr

parkr Dec 29, 2016

Member

Perhaps an example here would be useful. The user may still be wondering what the full path is they need to create in their site.

This comment has been minimized.

@tomjoht

tomjoht Dec 29, 2016

Contributor

good call. updated.

@tomjoht

tomjoht Dec 29, 2016

Contributor

good call. updated.

Show outdated Hide outdated docs/_docs/themes.md
The `jekyll new <PATH>` command isn't the only way to create a new Jekyll site with a gem-based theme. You can also find gem-based themes online and incorporate them into your Jekyll project.
For example, search for [jekyll-theme on RubyGems](https://rubygems.org/search?utf8=%E2%9C%93&query=jekyll-theme) to find other gem-based themes. (Note that not all themes are using `jekyll-theme` as a convention in the theme name.)

This comment has been minimized.

@parkr

parkr Dec 29, 2016

Member

I would remove the hyphen and simply use "jekyll theme".

@parkr

parkr Dec 29, 2016

Member

I would remove the hyphen and simply use "jekyll theme".

This comment has been minimized.

@ashmaroli

ashmaroli Dec 29, 2016

Member

@parkr Frank suggested querying for jekyll-theme to display the new themes supported by GitHub Pages gem

@ashmaroli

ashmaroli Dec 29, 2016

Member

@parkr Frank suggested querying for jekyll-theme to display the new themes supported by GitHub Pages gem

This comment has been minimized.

@tomjoht

tomjoht Dec 29, 2016

Contributor

searches for "jekyll theme" return the same as for "jekyll-theme". removing hyphen.

@tomjoht

tomjoht Dec 29, 2016

Contributor

searches for "jekyll theme" return the same as for "jekyll-theme". removing hyphen.

Show outdated Hide outdated docs/_docs/themes.md
You can have multiple themes listed in your site's `Gemfile`, but only one theme can be selected in your site's `_config.yml`.
{: .note .info }
If you're publishing your Jekyll site on [Github Pages](https://pages.github.com/), note that Github Pages supports only some gem-based themes. See [Supported Themes](https://pages.github.com/themes/) in Github's documentation to see which themes are supported.

This comment has been minimized.

@parkr

parkr Dec 29, 2016

Member

Github ~> GitHub

@parkr

parkr Dec 29, 2016

Member

Github ~> GitHub

This comment has been minimized.

@tomjoht

tomjoht Dec 29, 2016

Contributor

updated

@tomjoht

tomjoht Dec 29, 2016

Contributor

updated

made updates from Parkr's review
- most prominent update is example of how to override minima default
@tomjoht

This comment has been minimized.

Show comment
Hide comment
@tomjoht

tomjoht Dec 29, 2016

Contributor

I made the updates from Parkr's review.

Contributor

tomjoht commented Dec 29, 2016

I made the updates from Parkr's review.

@tomjoht

This comment has been minimized.

Show comment
Hide comment
@tomjoht

tomjoht Dec 29, 2016

Contributor

I saw this issue: https://talk.jekyllrb.com/t/i-want-to-change-the-style-of-my-jekyll-website/3202/11. Should I add this note into the themes doc update here?

when you need to override a sass partial in minima, you will have to copy over both _sass/minima.scss and the sass partial to be overridden (_sass/minima/_layouts.scss in your case.) to the source directory.

or is this a bug that we'll soon be fixing? it seems like overriding styles would be very common.

Contributor

tomjoht commented Dec 29, 2016

I saw this issue: https://talk.jekyllrb.com/t/i-want-to-change-the-style-of-my-jekyll-website/3202/11. Should I add this note into the themes doc update here?

when you need to override a sass partial in minima, you will have to copy over both _sass/minima.scss and the sass partial to be overridden (_sass/minima/_layouts.scss in your case.) to the source directory.

or is this a bug that we'll soon be fixing? it seems like overriding styles would be very common.

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Dec 29, 2016

Member

@tomjohnson1492 Let's deal with later, let's merge this first. Small steps.

Member

DirtyF commented Dec 29, 2016

@tomjohnson1492 Let's deal with later, let's merge this first. Small steps.

@DirtyF

DirtyF approved these changes Dec 29, 2016

@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

ashmaroli Dec 29, 2016

Member

I saw this issue

@tomjohnson1492 I had also opened a dedicated issue ticket for it at #5704 You may subscribe to it and create a PR to update our documentation if that is the stance Jekyll Core takes..

Member

ashmaroli commented Dec 29, 2016

I saw this issue

@tomjohnson1492 I had also opened a dedicated issue ticket for it at #5704 You may subscribe to it and create a PR to update our documentation if that is the stance Jekyll Core takes..

@DirtyF

DirtyF approved these changes Jan 8, 2017

👍

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Jan 8, 2017

Member

If someone from @jekyll/documentation would kindly review this, it would be much appreciated ❤️

Member

DirtyF commented Jan 8, 2017

If someone from @jekyll/documentation would kindly review this, it would be much appreciated ❤️

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Jan 24, 2017

Member

@jekyllbot: merge +doc

Member

DirtyF commented Jan 24, 2017

@jekyllbot: merge +doc

@jekyllbot jekyllbot merged commit f552652 into jekyll:master Jan 24, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

jekyllbot added a commit that referenced this pull request Jan 24, 2017

parkr added a commit that referenced this pull request Jan 26, 2017

Merge branch 'master' into release-3-4-0
* master: (39 commits)
  Update history to reflect merge of #5798 [ci skip]
  Update history to reflect merge of #5822 [ci skip]
  use logger.info
  run codeclimate after success
  Update history to reflect merge of #5819 [ci skip]
  Fixed inaccuracy in "Built-in permalink styles" docs [skip ci]
  Update history to reflect merge of #5802 [ci skip]
  Update history to reflect merge of #5811 [ci skip]
  Update history to reflect merge of #5690 [ci skip]
  Update history to reflect merge of #5815 [ci skip]
  Review CI pages
  Rework CI doc to include multiple providers.
  Update history to reflect merge of #5812 [ci skip]
  Add jekyll-ga plug-in
  Update configuration.md
  Add mention of classifier-reborn for LSI
  Update history to reflect merge of #5810 [ci skip]
  Got that diaper money?
  Added note about --blank flag
  Update history to reflect merge of #5797 [ci skip]
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment