New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mention of classifier-reborn for LSI #5811
Conversation
classifier-reborn is mandatory for LSI since Jekyll 3.0
Thanks @nhoizey 😉 It's not mentioned on the variables page either, but if you try to run a build with the $ bundle exec jekyll build --lsi
...
Generating...
Dependency Error: Yikes! It looks like you don't have classifier-reborn or one of its dependencies installed. In order to use Jekyll as currently configured, you'll need to install this gem. The full error message from Ruby is: 'cannot load such file -- classifier-reborn' If you run into trouble, you can find helpful resources at http://jekyllrb.com/help/!
ERROR: YOUR SITE COULD NOT BE BUILT:
------------------------------------
classifier-reborn |
@@ -233,7 +233,7 @@ class="flag">flags</code> (specified on the command-line) that control them. | |||
<tr class="setting"> | |||
<td> | |||
<p class="name"><strong>LSI</strong></p> | |||
<p class="description">Produce an index for related posts.</p> | |||
<p class="description">Produce an index for related posts. The <a href="http://www.classifier-reborn.com/">classifier-reborn</a> plugin must be used.</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about simply: "( Requires classifier-reborn plugin )" ?
@DirtyF should I make also a PR for the variables page, then? Or maybe should the |
@nhoizey i believe it should be fine to edit both pages in the scope of this PR |
@nhoizey I understand you feel it's kind of a false promise as if you install I don't think @jekyll/core intend to remove completely the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR looks good to me with the added link/note here.
@jekyllbot: merge +doc |
* master: (39 commits) Update history to reflect merge of #5798 [ci skip] Update history to reflect merge of #5822 [ci skip] use logger.info run codeclimate after success Update history to reflect merge of #5819 [ci skip] Fixed inaccuracy in "Built-in permalink styles" docs [skip ci] Update history to reflect merge of #5802 [ci skip] Update history to reflect merge of #5811 [ci skip] Update history to reflect merge of #5690 [ci skip] Update history to reflect merge of #5815 [ci skip] Review CI pages Rework CI doc to include multiple providers. Update history to reflect merge of #5812 [ci skip] Add jekyll-ga plug-in Update configuration.md Add mention of classifier-reborn for LSI Update history to reflect merge of #5810 [ci skip] Got that diaper money? Added note about --blank flag Update history to reflect merge of #5797 [ci skip] ...
classifier-reborn is mandatory for LSI since Jekyll 3.0