Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

site template: Use plugins key instead of gems #6045

Merged
merged 1 commit into from
Jul 10, 2017
Merged

site template: Use plugins key instead of gems #6045

merged 1 commit into from
Jul 10, 2017

Conversation

DirtyF
Copy link
Member

@DirtyF DirtyF commented Apr 22, 2017

Since #5130 we are encouraged to use plugins key rather than gems in config.yml

This should be merged only when GitHub Pages has updated to next release.

@DirtyF DirtyF added this to the 3.5 milestone Apr 22, 2017
@DirtyF DirtyF requested a review from benbalter April 22, 2017 14:21
@ashmaroli
Copy link
Member

Shouldn't this be added to Milestone 3.5.1 instead?

@DirtyF DirtyF modified the milestones: 3.5, 3.6 Jun 18, 2017
@DirtyF DirtyF mentioned this pull request Jun 20, 2017
Closed
@DirtyF DirtyF requested a review from pathawks June 20, 2017 07:00
@DirtyF
Copy link
Member Author

DirtyF commented Jun 20, 2017

Waiting for github/pages-gem#449

@DirtyF DirtyF mentioned this pull request Jun 23, 2017
Merged
@DirtyF DirtyF mentioned this pull request Jul 3, 2017
Closed
@parkr
Copy link
Member

parkr commented Jul 5, 2017

If you separated this into two PR's – one for the example and one for the docs site – then we could merge one and wait on the other, rather than holding both up due to the latter's dependency on Pages. Should I merge #6169 and this can be just for the docs site?

@DirtyF DirtyF changed the title Use plugins key instead of gems site template: Use plugins key instead of gems Jul 5, 2017
@DirtyF
Copy link
Member Author

DirtyF commented Jul 5, 2017 •
edited
Loading

@parker You're right, updated this branch with example only so that you can merge it.
We'll just have to revert #6110 once GitHub Pages will run Jekyll 3.5+.

@benbalter
Copy link
Contributor

@jekyllbot: merge +minor.

@jekyllbot jekyllbot merged commit 59a4223 into master Jul 10, 2017
@jekyllbot jekyllbot deleted the gems-to-plugins branch July 10, 2017 13:46
@benbalter
Copy link
Contributor

🎉 💥 🌮 @DirtyF!

jekyllbot added a commit that referenced this pull request Jul 10, 2017
@jekyllbot
Update history to reflect merge of #6045 [ci skip]
c7d98ca
@DirtyF DirtyF marked this as a duplicate of #6196 Jul 24, 2017
@alzeih alzeih mentioned this pull request Jul 28, 2017
Closed
@jekyll jekyll locked and limited conversation to collaborators Jul 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@parkr parkr parkr approved these changes

@pathawks pathawks pathawks approved these changes

@benbalter benbalter benbalter approved these changes

Assignees
No one assigned
Labels
frozen-due-to-age
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.
6 participants
@DirtyF @ashmaroli @parkr @benbalter @pathawks @jekyllbot