New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

site template: Use plugins key instead of gems #6045

Merged
merged 1 commit into from Jul 10, 2017

Conversation

Projects
None yet
6 participants
@DirtyF
Member

DirtyF commented Apr 22, 2017

Since #5130 we are encouraged to use plugins key rather than gems in config.yml

This should be merged only when GitHub Pages has updated to next release.

@DirtyF DirtyF added the do-not-merge label Apr 22, 2017

@DirtyF DirtyF added this to the 3.5 milestone Apr 22, 2017

@DirtyF DirtyF requested a review from benbalter Apr 22, 2017

@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

ashmaroli Apr 22, 2017

Member

Shouldn't this be added to Milestone 3.5.1 instead?

Member

ashmaroli commented Apr 22, 2017

Shouldn't this be added to Milestone 3.5.1 instead?

@DirtyF DirtyF modified the milestones: 3.5, 3.6 Jun 18, 2017

@DirtyF DirtyF removed the do-not-merge label Jun 19, 2017

@DirtyF DirtyF requested a review from pathawks Jun 20, 2017

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF
Member

DirtyF commented Jun 20, 2017

Waiting for github/pages-gem#449

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jul 5, 2017

Member

If you separated this into two PR's – one for the example and one for the docs site – then we could merge one and wait on the other, rather than holding both up due to the latter's dependency on Pages. Should I merge #6169 and this can be just for the docs site?

Member

parkr commented Jul 5, 2017

If you separated this into two PR's – one for the example and one for the docs site – then we could merge one and wait on the other, rather than holding both up due to the latter's dependency on Pages. Should I merge #6169 and this can be just for the docs site?

@DirtyF DirtyF changed the title from Use plugins key instead of gems to site template: Use plugins key instead of gems Jul 5, 2017

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Jul 5, 2017

Member

@parker You're right, updated this branch with example only so that you can merge it.
We'll just have to revert #6110 once GitHub Pages will run Jekyll 3.5+.

Member

DirtyF commented Jul 5, 2017

@parker You're right, updated this branch with example only so that you can merge it.
We'll just have to revert #6110 once GitHub Pages will run Jekyll 3.5+.

@parkr

parkr approved these changes Jul 10, 2017

@benbalter

This comment has been minimized.

Show comment
Hide comment
@benbalter

benbalter Jul 10, 2017

Contributor

@jekyllbot: merge +minor.

Contributor

benbalter commented Jul 10, 2017

@jekyllbot: merge +minor.

@jekyllbot jekyllbot merged commit 59a4223 into master Jul 10, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jekyllbot jekyllbot deleted the gems-to-plugins branch Jul 10, 2017

@benbalter

This comment has been minimized.

Show comment
Hide comment
@benbalter

benbalter Jul 10, 2017

Contributor

🎉 💥 🌮 @DirtyF!

Contributor

benbalter commented Jul 10, 2017

🎉 💥 🌮 @DirtyF!

jekyllbot added a commit that referenced this pull request Jul 10, 2017

@DirtyF DirtyF marked this as a duplicate of #6196 Jul 24, 2017

@alzeih alzeih referenced this pull request Jul 28, 2017

Closed

Change RSS references #129

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment