New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #6498: Use Gem to discover the location of bundler. #6499
Conversation
Never mind. I don't think that's going to be an issue. Just going to wait for Travis to tell me it's green and then I'll merge. |
Isn't the error on Appveyor related? |
Looks that way. I'm going to hold off on this then until that's fixed. I know Windows isn't officially supported but I don't see a reason to merge something that we know is going to regress that platform. |
just confirmed.. I was unable to run |
Code looks good but the windows build needs fixing.
@envygeeks The issue here is that Windows doesn't parse the shebang But in the context of this PR, you can achieve the same by passing - process, output = Jekyll::Utils::Exec.run(exe, "install")
+ process, output = Jekyll::Utils::Exec.run("ruby", exe, "install") |
I'll get it fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@jekyllbot: merge +dev |
No description provided.