-
-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loggers should accept both numbers and symbols #6967
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jekyll's logger should start trying to conform to standard logging practices in Ruby. That said, the logger level should accept both a `:symbol` (if you really want,) and a number, this way users aren't taken aback when they know what log level they want. This commit makes it so that the logger level can be set normally and within Jekyll's own constraints. ```ruby Jekyll.logger.log_level = 0 Jekyll.logger.log_level = Logger::DEBUG Jekyll.logger.log_level = :debug ```
DirtyF
approved these changes
Apr 30, 2018
@pathawks How does this benefit our regular users or plugin developers..? |
@ashmaroli I think the benefit here is that it makes our logger behave more like standard Ruby loggers. |
okay.. will review after the tests pass.. |
pathawks
force-pushed
the
envygeeks-patch-1
branch
from
April 30, 2018 18:17
c47a20c
to
9926616
Compare
@ashmaroli Travis is now ✅ |
(explicitly requesting a review from @parkr (instead of a team) because something about this doesn't feel right to me..) |
ghost
approved these changes
May 1, 2018
@jekyllbot: merge +dev |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #6305: