Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest sites use OpenSSL instead of GnuTLS for their site's CI #7010

Merged
merged 1 commit into from
Sep 24, 2018
Merged

Suggest sites use OpenSSL instead of GnuTLS for their site's CI #7010

merged 1 commit into from
Sep 24, 2018

Conversation

idgman
Copy link
Contributor

@idgman idgman commented May 13, 2018

By default, the test runs with GnuTLS. I experienced problems in testing various external sites as GnuTLS doesn't recognize some of the certificates. By using OpenSSL, these certificates are trusted.

By default, the test runs with GnuTLS. I experienced problems in testing various external sites as GnuTLS doesn't recognize some of the certificates. By using OpenSSL, the certificates are trusted.
@DirtyF DirtyF requested a review from a team May 13, 2018 20:21
@DirtyF DirtyF added the tests label May 13, 2018
@pathawks
Copy link
Member

pathawks commented May 14, 2018

Could we add a comment in the YAML explaining what this package is used for? There could be a point in the future where GnuTLS works better than OpenSSL, and we should give people the option of disabling this if they want

@pathawks pathawks changed the title Use OpenSSL instead of GnuTLS Suggest sites use OpenSSL instead of GnuTLS for their site's CI May 14, 2018
@kenman345
Copy link
Contributor

Note: HTML-Proofer documentation actually makes this recommendation for optimal configuration/compatibility.

Copy link
Member

@parkr parkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No other configuration is necessary?

@kenman345
Copy link
Contributor

Actually, its also recommended to add
- ca-certificates

to the packages section defined for the openssl thing.

@DirtyF
Copy link
Member

DirtyF commented Sep 24, 2018

@jekyllbot: merge +docs

@jekyllbot jekyllbot merged commit 81792c2 into jekyll:master Sep 24, 2018
jekyllbot added a commit that referenced this pull request Sep 24, 2018
@jekyll jekyll locked and limited conversation to collaborators Sep 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants