Do not process Liquid in post excerpt when disabled in front matter

[kenman345]

As noted in #6824 the latest feature to disable liquid rendering did not extend to excerpts. This is a bit of a simple copy and past of logic. I do not exactly understand how to add the updated tests for it but figured someone might be able to help me move it along.

[pathawks]

Take a look at some of the existing tests for excerpts and the test that I added for disabled Liquid and see if you can figure out what kind of test needs to be added.

If that isn't enough to get you started, please @ me and I can help you out 🍻

[pathawks]

How do we want to list this in the v4.0.0 changelog? It is a follow-up to #6824, which won't be included until v4, so I worry that listing this as a bugfix might be misleading. I also don't want to be tempted to backport this to v3.8.x

[kenman345]

It’s bring the other enhancement to be more feature complete. Maybe don’t list it but modify the original changelog to include this ticket as well?

…

On Fri, Jul 20, 2018 at 6:24 PM Pat Hawks ***@***.***> wrote: How do we want to list this in the v4.0.0 changelog? It is a follow-up to #6824 <#6824>, which won't be included until v4, so I worry that listing this as a bugfix might be misleading. I also don't want to be tempted to backport this to v3.8.x — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#7146 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AKeM1-CjXcaxacrVBVfv_VMzXU683mh6ks5uIlivgaJpZM4VS_2e> .

[pathawks]

@jekyllbot: 🚢 +feature

[pathawks]

jekyll/History.markdown

Lines 85 to 88 in fe0a6ca

	### feature
	* Disable Liquid via front matter (#6824)
	* Do not process Liquid in post excerpt when disabled in front matter (#7146)

The features are listed consecutively in History, this seems fine 👍

[pathawks]

Wait a second... +feature is not a thing. These both should have been +major.

sigh

[kenman345]

@pathawks I know this isn’t the right forum but is their a way in which excerpt can be changed so that we process the liquid once between excerpt and the full page? It seems a bit like extra leg work many people might not ever make use of anyways. Seems like potential performance to be had for larger sites.

[pathawks]

@kenman345 That might be a good idea 👍

[kenman345]

I will take a deep dive into it and see what shakes out. I’ll open a PR if I feel comfortable with a proposed change to squeeze away the extra cycles this adds.

…

On Fri, Jul 20, 2018 at 7:36 PM Pat Hawks ***@***.***> wrote: @kenman345 <https://github.com/kenman345> That might be a good idea 👍 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#7146 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AKeM18RlkUgB46nIAjc1cCUth8E7uWrEks5uImmQgaJpZM4VS_2e> .