Incorporate relative_url within post_url tag

[ashmaroli]

• This is a 🙋 feature or enhancement.
• I've added tests
• I've adjusted the documentation (via spec.post_intall_message)

Summary

With this, {% post_url 2019-03-27-hello %} will return /blog/2019/03/27/hello.html for a site configured with baseurl: blog

BREAKING-CHANGE

Context

Resolves #7353

[update-docs]

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update some of our documentation based on your changes.

[DirtyF]

Thanks Ashwin 🥇

[ashmaroli]

@DirtyF I've documented this change within the gemspec's post_install_message. Isn't that enough?

[chrisfinazzo]

As this is a breaking change for nearly everything, would it be appropriate to put this info in a warning block to remind people they will need to fix their links? 🤔

[ashmaroli]

be appropriate to put this info in warning block

@chrisfinazzo Sounds fair. I'll add a warning block to the upgrading docs

[DirtyF]

👍 on the feature,

No need for a red warning in the docs, it's a major bump, so you should expect breaking changes.

[chrisfinazzo]

@DirtyF, I guess... 👌🏼

My only point there was because this change affects a fundamental behavior that has worked in a certain way for so so so long, it feels half-assed to not highlight this since almost everyone will encounter it at some point.

[DirtyF]

@chrisfinazzo we have a post-install message for everyone to see.

People might get confused though because the link path will change and this can remained unnoticed because we won't output a warning in the console, and not everyone has automatic link validation with tools link htmlproofer.

[DirtyF]

@jekyllbot: merge +major

[mattr-]

I appreciate that there's a warning for this feature now. Not everybody is going to read the post install message. With a change like this, it's important to highlight it in as many ways as possible and I'm glad that's what we're doing here. Thanks everybody! ❤️