Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve links (http -> https) #9064

Merged
merged 1 commit into from
Jun 21, 2022
Merged

Improve links (http -> https) #9064

merged 1 commit into from
Jun 21, 2022

Conversation

deining
Copy link
Contributor

@deining deining commented May 20, 2022

This is a 🔦 documentation change.

  • I've adjusted the documentation (if it's a feature or enhancement)

Summary

This PR changes multiple links from http to https.

phieri
phieri reviewed Jun 11, 2022
View reviewed changes
test/source/symlink-test/symlinked-file-outside-source Outdated
C:/etc/passwd
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't match the PR description. Is it a deliberate change?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reverted.

parkr
parkr reviewed Jun 20, 2022
View reviewed changes
Copy link
Member

@parkr parkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests failing due to a change in a test spec file.

test/source/symlink-test/symlinked-file-outside-source Outdated
C:/etc/passwd
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reverted.

test/source/symlink-test/symlinked-file-outside-source Outdated Show resolved Hide resolved
@deining deining force-pushed the contrib branch 2 times, most recently from 1740c34 to de78cce Compare June 20, 2022 19:58
@deining deining requested a review from parkr June 20, 2022 20:04
parkr
parkr approved these changes Jun 20, 2022
View reviewed changes
Copy link
Member

@parkr parkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jekyllbot: merge +docs

parkr
parkr approved these changes Jun 21, 2022
View reviewed changes
Copy link
Member

@parkr parkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jekyllbot: merge +docs

@parkr
Copy link
Member

parkr commented Jun 21, 2022

@jekyllbot: merge +docs

parkr
parkr approved these changes Jun 21, 2022
View reviewed changes
Copy link
Member

@parkr parkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jekyllbot: merge +docs

parkr
parkr approved these changes Jun 21, 2022
View reviewed changes
Copy link
Member

@parkr parkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jekyllbot: merge +docs

@jekyllbot jekyllbot merged commit a0c6b4c into jekyll:master Jun 21, 2022
jekyllbot added a commit that referenced this pull request Jun 21, 2022
@jekyllbot
Update history to reflect merge of #9064 [ci skip]
3d23171
github-actions bot pushed a commit that referenced this pull request Jun 21, 2022
@jekyllbot
Deploy docs from a0c6b4c
2d13d42 
Andreas Deininger: Improve links (http -> https) (#9064)

Merge pull request 9064
@parkr
Copy link
Member

parkr commented Jun 21, 2022

Sorry about that! There was a GitHub Webhooks outage, then there were a couple bugs to work out in our jekyllbot code. 😄

@deining deining deleted the contrib branch June 21, 2022 05:51
@jekyll jekyll locked and limited conversation to collaborators Jun 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@phieri phieri phieri left review comments

@parkr parkr parkr approved these changes

Assignees
No one assigned
Labels
documentation frozen-due-to-age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@deining @parkr @phieri @jekyllbot