Optimize Site#each_site_file
#9187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashmaroli
added
fix
refactor
backport-candidate
|
@jekyllbot: merge +fix |
jekyllbot
added a commit
that referenced
this pull request
Dec 18, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Dec 18, 2022
Ashwin Maroli: Optimize `Site#each_site_file` (#9187) Merge pull request 9187
ashmaroli
added a commit
to ashmaroli/jekyll
that referenced
this pull request
Jan 15, 2023
This backports b2891a4 to 4.3-stable
ashmaroli
added a commit
that referenced
this pull request
Jan 16, 2023
This backports b2891a4 to 4.3-stable
DavidS
added a commit
to DavidS/jekyll
that referenced
this pull request
Apr 29, 2023
This reverts commit b2891a4.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Site#each_site_filereduced in performance in Jekyll v4.3.0 owing to additional checks to filter duplicate entries of static files from a collection.This pull request optimizes the regression by avoiding duplicate entries of static files itself thereby removing the need for additional checks and filtering.
Notes
Consider backporting to the
4.3-stablebranch.