Update dependency @openzeppelin/contracts-upgradeable to v4.4.2 [SECURITY] #311
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
4.4.1
->4.4.2
GitHub Vulnerability Alerts
GHSA-m6w8-fq7v-ph4m
Impact
The
GovernorCompatibilityBravo
module may lead to the creation of governance proposals that execute function calls with incorrect arguments due to bad ABI encoding. This happens if the proposal is created using explicit function signatures, e.g. a proposal to invoke the functionfoo(uint256)
is created aspropose([target], [0], ["foo(uint256)"], ["0x00..01"])
. If the function selector is provided as part of the encoded proposal data the issue is not present, e.g. the same proposal is created aspropose([target], [0], ["0x2fbebd3800..01"])
, where2fbebd38
is the function selector.We've assessed the instances of this contract found on chain, and did not find any occurrence of this bug in the past. Proposal creation through Tally or OpenZeppelin Defender is not affected. The core
Governor
contract on its own is not affected.Patches
A fix is included in version v4.4.2 of
@openzeppelin/contracts
and@openzeppelin/contracts-upgradeable
.Workarounds
Do not create proposals using explicit function signatures. Instead, use the
propose
function without thesignatures
argument, and create the proposal using the fully ABI-encoded function call including the function selector in thecalldatas
argument as explained above.References
OpenZeppelin/openzeppelin-contracts#3099
Credits
This issue was identified and reported by @GeraldHost.
For more information
If you have any questions, comments, or need assistance regarding this advisory, email us at security@openzeppelin.com.
To submit security reports please use our bug bounty on Immunefi.
Release Notes
OpenZeppelin/openzeppelin-contracts-upgradeable
v4.4.2
Compare Source
Bugfixes
GovernorCompatibilityBravo
: Fix error in the encoding of calldata for proposals submitted through the compatibility interface with explicit signatures. (#3100)Configuration
📅 Schedule: "" (UTC).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by WhiteSource Renovate. View repository job log here.