Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement support for Jellyscrub plug-in or otherwise support using BIF files and JSON manifests to implement timeline scrubbing #3316

Closed
stpettersens opened this issue Jan 16, 2024 · 9 comments
Labels
enhancement New feature or request

Comments

@stpettersens
Copy link

stpettersens commented Jan 16, 2024

"Trickplay" thumbnails in timeline

There is a plugin called Jellyscrub which adds support to the Web client to generate thumbnails on the video timeline. It does this by generating BIF files and JSON manifest files:

https://github.com/nicknsy/jellyscrub

The thumbnails in the timeline are then supported in the Web client and the Android (non-TV) client.

My request is not to support the generation of the BIF and JSON manifests for timeline thumbnails, but to support the thumbnails generated via the Web client in the Android TV client. Probably this should be done independently of the Jellyscrub plugin itself, but can rely on such a plugin in the Web client to generate the BIFs and JSON manifests that the Android TV client can use to provide the scrubbing.

Thanks.

@stpettersens stpettersens added the enhancement New feature or request label Jan 16, 2024
@nielsvanvelzen
Copy link
Member

Official Jellyfin clients do not support third-party plugins.

@nielsvanvelzen nielsvanvelzen closed this as not planned Won't fix, can't repro, duplicate, stale Jan 17, 2024
@woolmonkey
Copy link

Sure but the web client supports third party plugins.

@nielsvanvelzen
Copy link
Member

No it does not

@woolmonkey
Copy link

Must be my imagination that I can load plugins. And they work in the web page.

@thornbill
Copy link
Member

Copied from the Jellyscrub README:

If your Jellyfin's web path is set, the plugin should automatically inject the companion client script into the "index.html" file of the web server directory. Otherwise, the line <script plugin="Jellyscrub" version="1.0.0.0" src="/Trickplay/ClientScript"></script> will have to be added at the end of the body tag manually right before . If you have a base path set, change src="/Trickplay/ClientScript" to src="/YOUR_BASE_PATH/Trickplay/ClientScript".

It is not supported by web without making modifications to the built files... and we definitely do not provide any official support for doing that.

Let's remember to be respectful though. Arguing with maintainers won't get you anywhere.

@stpettersens
Copy link
Author

stpettersens commented Jan 21, 2024

Must be my imagination that I can load plugins. And they work in the web page.

This particular plug-in will work with the Android version, but not the TV version.
I think it is not officially supported by any official Jellyfin client because it is third-party.

@thornbill
Copy link
Member

Fwiw official support for image previews has been merged in the server in unstable so that plugin will likely become obsolete in the 10.9.0 release.

@stpettersens
Copy link
Author

stpettersens commented Jan 21, 2024 via email

@JVT038
Copy link

JVT038 commented May 13, 2024

Can this issue be reopened? 10.9.0 has been released with a native trickplay feature. Therefore, I think this issue has become relevant again, because it's no longer a third-party plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants