Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for BDMV movie directories in native playback mode #330

Merged
merged 2 commits into from Jul 7, 2020

Conversation

YK-Samgo
Copy link

@YK-Samgo YK-Samgo commented Jun 27, 2020

Add support for BDMV movies in the bluray directry by pointing the file to ./BDMV/index.bdmv when using direct path
related issue #33

Originally, kodi can't play the movie synced by jellyfin for kodi with Playback mode: Native (direct paths) if the bdmv is in a directry like this:
Casino.Royale.2006.COMPLETE.UHD.BLURAY-COASTER/
.
└── Casino.Royale.2006.COMPLETE.UHD.BLURAY-COASTER
├── BDMV
│   ├── BACKUP
│   ├── BDJO
│   ├── CLIPINF
│   ├── JAR
│   ├── META
│   ├── PLAYLIST
│   ├── STREAM
│   ├── index.bdmv
│   └── MovieObject.bdmv
├── CERTIFICATE
│   ├── BACKUP
│   ├── app.discroot.crt
│   ├── bu.discroot.crt
│   └── id.bdmv
├── Casino.Royale.2006.COMPLETE.UHD.BLURAY-COASTER.nfo
├── fanart.jpg
├── landscape.jpg
├── logo.png
└── poster.jpg

Jellyfin server tells jellyfin for kodi only the directry of the bdmv, in this case, Casino.Royale.2006.COMPLETE.UHD.BLURAY-COASTER, but kodi needs the 'BDMV/index.bdmv' file, which, in this case, should be Casino.Royale.2006.COMPLETE.UHD.BLURAY-COASTER/BDMV/index.bdmv. So just give kodi what it wants.

@sonarcloud
Copy link

sonarcloud bot commented Jun 27, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@mcarlton00 mcarlton00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I don't have any bluray rips so I can't test this myself, but the code itself looks fine

@holow29
Copy link
Contributor

holow29 commented Jun 28, 2020

Not sure if you want to do this separately or not, but you might consider doing the same for DVD folders to point to VIDEO_TS.IFO inside VIDEO_TS folder. (Such as /folder/Casino Royale (DVD)/VIDEO_TS/VIDEO_TS.IFO)

@mcarlton00
Copy link
Member

I'd suggest doing so separately just so it's easier to track down if we ever need to find it again.

@holow29 if you're able to test this change reasonably soon it'd be super helpful (nobody on the dev team is currently set up for native mode/has raw bluray rips). If you can't then it's not a big deal, I'll merge it anyway. Just having confirmation before merging is always nice 😄

@holow29
Copy link
Contributor

holow29 commented Jun 28, 2020

Hmm so I am trying to test (a bit remotely), and I'm having some difficulty because now I am getting something to play, but it is not the correct movie (but always the same incorrect movie). What is happening is similar to before where I click a video tile and the interface seems to reload briefly (maybe then placing the wrong movie under my 'cursor'); the change is that whereas before nothing would play, now something is playing (but the wrong thing, as I said).

@mcarlton00
Copy link
Member

Perhaps I've missed something, but I was under the impression that this PR was fixing bluray playback for native mode, and that native mode was only accessible from on the same LAN as your server. So I'm not entirely sure how you could be testing this remotely.

@holow29
Copy link
Contributor

holow29 commented Jul 2, 2020

I meant that I am not at my setup at the moment, but others are - so I was trying to remotely walk them through some tests. It's a little difficult this way.

@YK-Samgo YK-Samgo mentioned this pull request Jul 7, 2020
@oddstr13 oddstr13 changed the title add support for BDMV movies in the bluray directry Add support for BDMV movie directories in native playback mode Jul 7, 2020
@oddstr13 oddstr13 merged commit 44d4080 into jellyfin:master Jul 7, 2020
@oddstr13 oddstr13 added the Native Mode Issue is related to Native playback mode label Jul 7, 2020
@oddstr13 oddstr13 mentioned this pull request Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Native Mode Issue is related to Native playback mode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants