Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BDMV and DVD Rip support in TV Shows #384

Merged
merged 1 commit into from
Sep 4, 2020

Conversation

holow29
Copy link
Contributor

@holow29 holow29 commented Sep 4, 2020

Porting @YK-Samgo's work from Movies to TV Shows for native mode.
Related:
#334
#330

Porting @YK-Samgo's work from Movies.py to TVShows.py
@sonarcloud
Copy link

sonarcloud bot commented Sep 4, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
92.9% 92.9% Duplication

@holow29
Copy link
Contributor Author

holow29 commented Sep 4, 2020

Can someone please help me test this? I must be stupid, but I can't get Kodi to install this addon manually...I've tried adding addon.xml and I've tried replacing tvshows.py (from this PR) into the 0.5.9 release while removing the .pyo. What am I doing wrong?

@mcarlton00
Copy link
Member

Try downloading the right zip for your Kodi version from here: https://dev.azure.com/jellyfin-project/jellyfin/_build/results?buildId=13821&view=artifacts&type=publishedArtifacts. You can download from the 3 dots on the right side.

Kodi 18 and below is py2
Kodi 19 is py3

@holow29
Copy link
Contributor Author

holow29 commented Sep 4, 2020

Thank you! That worked. I guess I didn't think it had to be 'built'.
Anyway, TV Shows are now playing for me even if it is a DVD or Blu-Ray rip, so in my view, this PR is successful.

@mcarlton00
Copy link
Member

Basically it's just creating a zip file with the proper structure, but it is a bit finnicky until you get the hang of it. In the future I'd like to get the pipeline to attach a link to the generated zips to PRs, but haven't had the time to figure it out yet.

Copy link
Member

@mcarlton00 mcarlton00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no method of testing this currently, but the code looks good

@mcarlton00 mcarlton00 merged commit c5f001d into jellyfin:master Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants