Greatly increase the amount of logging information. #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oddstr13
added
cleanup
oddstr13
commented
Jul 9, 2019
| @@ -1,447 +1,447 @@ | |||
| # -*- coding: utf-8 -*- | |||
There was a problem hiding this comment.
It seems this file had Windows file endings. Long live editorconfig?
oddstr13
commented
Jul 9, 2019
| @@ -334,6 +334,3 @@ def close_transcode(self, device_id): | |||
| return self._delete("Videos/ActiveEncodings", params={ | |||
| 'DeviceId': device_id | |||
| }) | |||
|
|
|||
| def delete_item(self, item_id): | |||
| return self.items("/%s" % item_id, "DELETE") | |||
There was a problem hiding this comment.
flake8 was kind enough to informing me that this was a duplicate definition.
You should be able to find the exact same code further up.
cvium
reviewed
Jul 10, 2019
dkanada
approved these changes
Jul 11, 2019
anthonylavado
approved these changes
Jul 11, 2019
cvium
approved these changes
Jul 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main change so far is to include file paths and line numbers on log output.
Log all calls to
__getitem__and__shortcuts__(DEBUG, noisy)Some flake8 errors corrected.
Currently prints some stacktraces that probably shouldn't be printed, but my opinion on that is to keep it like that until exception handling can be improved (and made much more specific) in those areas.
Also added editorconfig.