New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix transcoding problem when using 10.8 server #681
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried several files that previously failed and all played without issue.
in deviceCapabilities.brs, the "Value" of the "hevc" "VideoLevel" needs to be the float multiplied by 30, in my tests.
|
some of my subtitle changes are also required to prevent the erroneous transcoding, but im not sure which ones. probably just ass/ssa profiles of either embed/external type would be sufficient. |
Good catch, thanks. Updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had one file that wouldn't play because it needed transcoding that now plays fine with this PR. I also played a bunch of random files that needed transcoding and they all played as expected.
My setup is pretty simple though: local only server, 1080p TV, and a 2.1 soundbar.
Left a comment in the chat, but will put it here for a paper trail. I tested this again on the files I had problems with and everything worked without issue. |
Upon merge I believe this also fixes #694 |
In the current device profile, we specify that we support h264 profile level up to 5.1, whereas the Roku specification says they only support 4.0,4.1. In in the 10.7 releases, the maximum Profile Level the server would use was 4.1.
@nyanmisaka explained that hardware decoders may be able to decode higher profile levels but with some quality implications (e.g. 5.2 may play on 4.x hardware with macroblock artifacts). This seems to be the case with Roku when Direct Playing, but when transcoding the device will have more strict checking using the info from the play, so will just refuse to play.
In order to allow a user to reduce transcodes, and attempt direct play of videos where the only reason for transcoding is an unsupported profile level, a user setting was added. If the direct play fails, the transcoding url will be used instead.
Changes
Issues
fixes #670 #651